Re: [PATCH 5/5] blktrace: print human-readable act_mask

Steven Rostedt
2009-03-24T16:04:57Z

On Tue, 24 Mar 2009, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> >
> >
> > On Tue, 24 Mar 2009, Li Zefan wrote:
> > >
> > > +static ssize_t blk_trace_mask2str(char *buf, int mask)

> > > else if (attr == &dev_attr_act_mask)
> > > - ret = sprintf(buf, "%#x\n", q->blk_trace->act_mask);
> > > + ret = blk_trace_mask2str(buf, q->blk_trace->act_mask);

> > > - value = blk_str2act_mask(buf);
> > > - if (value < 0)
> > > + value = blk_trace_str2mask(buf);
> >
> > Hmm, does this compile? Doesn't blk_trace_str2mask need two parameters?
>
> No, it needs one parameter.

I'm really confused now. The prototype for blk_trace_str2mask has
two parameters. It is used with two parameters above, but then it is used
here with only one parameter. The blk_str2act_mask may have one, and that
is what is replaced.

What am I missing?

-- Steve