Re: [PATCH 5/5] blktrace: print human-readable act_mask

Ingo Molnar
2009-03-24T09:48:46Z

* Li Zefan <lizf@cn.fujitsu.com> wrote:

> > @@ -1432,9 +1456,11 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
> > if (attr == &dev_attr_act_mask) {
> > if (sscanf(buf, "%llx", &value) != 1) {
> > /* Assume it is a list of trace category names */
> > - value = blk_str2act_mask(buf);
> > - if (value < 0)
> > + value = blk_trace_str2mask(buf);
> > + if (value < 0) {
> > + ret = value;
> > goto out;
> > + }
>
> value is u64, it can < 0.

Ok. Small nit: please in such cases change the subject line back to
something like:

[PATCH 5/5, v2] blktrace: print human-readable act_mask

So that's it's easy to see which is the latest version, in thread
view.

Ingo