Re: [PATCH 3/5] blktrace: fix off-by-one bug

Li Zefan
2009-03-24T08:49:54Z

> Ah. This:
>
> [__BLK_TA_QUEUE] = {{ "Q", "queue" }, blk_log_generic },
> [__BLK_TA_BACKMERGE] = {{ "M", "backmerge" }, blk_log_generic },
> [__BLK_TA_FRONTMERGE] = {{ "F", "frontmerge" }, blk_log_generic },
> [__BLK_TA_GETRQ] = {{ "G", "getrq" }, blk_log_generic },
> [__BLK_TA_SLEEPRQ] = {{ "S", "sleeprq" }, blk_log_generic },
> [__BLK_TA_REQUEUE] = {{ "R", "requeue" }, blk_log_with_error },
> [__BLK_TA_ISSUE] = {{ "D", "issue" }, blk_log_generic },
> [__BLK_TA_COMPLETE] = {{ "C", "complete" }, blk_log_with_error },
> [__BLK_TA_PLUG] = {{ "P", "plug" }, blk_log_plug },
> [__BLK_TA_UNPLUG_IO] = {{ "U", "unplug_io" }, blk_log_unplug },
> [__BLK_TA_UNPLUG_TIMER] = {{ "UT", "unplug_timer" }, blk_log_unplug },
> [__BLK_TA_INSERT] = {{ "I", "insert" }, blk_log_generic },
> [__BLK_TA_SPLIT] = {{ "X", "split" }, blk_log_split },
> [__BLK_TA_BOUNCE] = {{ "B", "bounce" }, blk_log_generic },
> [__BLK_TA_REMAP] = {{ "A", "remap" }, blk_log_remap },
>
> does not have a __BLK_TA_ABORT entry currently - it should have,
> right?
>

Right, currently I'm not sure if blk_log_with_error is suitable for "abort" event,
so I haven't fixed it yet. :)