Re: [PATCH 3/5] blktrace: fix off-by-one bug

Li Zefan
2009-03-24T08:33:17Z

>> - if (unlikely(what == 0 || what > ARRAY_SIZE(what2act)))
>> + if (unlikely(what == 0 || what >= ARRAY_SIZE(what2act)))
>
> ah, nice. How did you notice - did we miss "remap" events due to
> this bug?
>

By code review, but we can get NULL dereference bug if we receive an
"abort" event, this event may be generated only when using device-mapper.

We don't print out this event currently, neither does the userspace
blktrace, which should be fixed.