Re: [PATCH 04/57] microblaze_v7: Open firmware files

[Michal Simek <monstr@monstr.eu>]

Arnd Bergmann wrote:
> On Wednesday 18 March 2009, monstr@monstr.eu wrote:
>> From: Michal Simek <monstr@monstr.eu>
>>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>>  arch/microblaze/include/asm/of_device.h   |   45 ++
>>  arch/microblaze/include/asm/of_platform.h |   64 ++
>>  arch/microblaze/include/asm/prom.h        |  313 ++++++++
>>  arch/microblaze/kernel/of_device.c        |  115 +++
>>  arch/microblaze/kernel/of_platform.c      |  201 +++++
>>  arch/microblaze/kernel/prom.c             | 1147 +++++++++++++++++++++++++++++
>>  arch/microblaze/kernel/prom_parse.c       | 1025 ++++++++++++++++++++++++++
>>  7 files changed, 2910 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/microblaze/include/asm/of_device.h
>>  create mode 100644 arch/microblaze/include/asm/of_platform.h
>>  create mode 100644 arch/microblaze/include/asm/prom.h
>>  create mode 100644 arch/microblaze/kernel/of_device.c
>>  create mode 100644 arch/microblaze/kernel/of_platform.c
>>  create mode 100644 arch/microblaze/kernel/prom.c
>>  create mode 100644 arch/microblaze/kernel/prom_parse.c
> 
> Since these files are derived from the powerpc versions, what is the
> plan on them? IIRC, you had them in a common directory in an earlier
> version. Are you planning to merge them at some point in the future
> or do you intend to maintain a fork?

yes, these files are defived from PPC version. Yes, I added them to generic
location and in this version are in arch folder. It is easier for me to have
them in arch folder till Microblaze will be in linus tree.
And then create patch which will synchronize them.

I prefer to have this code in generic location as much as possible but first
stage from my perspective should be add microblaze code to tree and then add it
to generic location and remove it from all archs which use it.

Thanks,
Michal

> 	Arnd <><


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854