From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 1/3] x86: fix set_extra_move_desc calling
Date: Tue, 24 Mar 2009 14:15:46 -0700 [thread overview]
Message-ID: <49C94D82.1040708@kernel.org> (raw)
In-Reply-To: <49C94134.4000408@kernel.org>
Impact: fix bug with desc moving when logical flat
Eric pointed out that should compare with old desc.
acctually this bug is introduced by:
| commit 22f65d31b25a320a5246592160bcb102d2791c45
|
| Author: Mike Travis <travis@sgi.com>
| Date: Tue Dec 16 17:33:56 2008 -0800
|
| x86: Update io_apic.c to use new cpumask API
|
| Impact: cleanup, consolidate patches, use new API
so need to move that before...
---
arch/x86/kernel/apic/io_apic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -592,8 +592,9 @@ set_desc_affinity(struct irq_desc *desc,
if (assign_irq_vector(irq, cfg, mask))
return BAD_APICID;
- cpumask_and(desc->affinity, cfg->domain, mask);
+ /* check that before desc->addinity get updated */
set_extra_move_desc(desc, mask);
+ cpumask_and(desc->affinity, cfg->domain, mask);
return apic->cpu_mask_to_apicid_and(desc->affinity, cpu_online_mask);
}
next prev parent reply other threads:[~2009-03-24 21:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 5:49 [RFC] Correct behaviour of irq affinity? Rusty Russell
2009-03-24 7:21 ` Yinghai Lu
2009-03-24 12:52 ` Rusty Russell
2009-03-24 20:36 ` Yinghai Lu
2009-03-24 12:39 ` Eric W. Biederman
2009-03-24 19:49 ` Yinghai Lu
2009-03-24 20:23 ` [PATCH] x86: fix set_extra_move_desc calling Yinghai Lu
2009-03-24 21:15 ` [tip:x86/apic] " Yinghai Lu
2009-03-24 21:15 ` Yinghai Lu [this message]
2009-03-24 21:16 ` [PATCH 2/3] x86: use default_cpu_mask_to_apicid for 64bit Yinghai Lu
2009-03-24 21:30 ` [tip:x86/apic] " Yinghai Lu
2009-03-24 21:34 ` Ingo Molnar
2009-03-24 21:42 ` [PATCH 3/3] x86: Correct behaviour of irq affinity -v2 Yinghai Lu
2009-03-24 21:17 ` [PATCH 3/3] x86: Correct behaviour of irq affinity Yinghai Lu
2009-03-24 21:30 ` [tip:x86/apic] " Rusty Russell
2009-03-25 17:51 ` Rusty Russell
2009-03-25 0:33 ` [RFC] Correct behaviour of irq affinity? Rusty Russell
2009-03-25 0:59 ` Rusty Russell
2009-03-25 1:03 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C94D82.1040708@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox