Re: mmotm 2009-03-23-22-34 uploaded (reiserfs)

Randy Dunlap
2009-03-25T15:14:13Z

Coly Li wrote:
> Hi Randy,
>
> Randy Dunlap Wrote:
>> akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2009-03-23-22-34 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>>>
>>> and will soon be available at
>>>
>>> git://git.zen-sources.org/zen/mmotm.git
>>>
>>> It contains the following patches against 2.6.29-rc8:
>>
>>> fs-reiserfs-return-f_fsid-for-statfs2-v2.patch
>> fs/built-in.o: In function `reiserfs_statfs':
>> super.c:(.text+0x7332b): undefined reference to `crc32_le'
>> super.c:(.text+0x7333f): undefined reference to `crc32_le'
>>
> Hmm, it should not be. The v2 patch includes linux/crc32.h, and I tested without
> any error. Now I am downloading mmotm to verify.

CONFIG_CRC32=m

Since reiserfs is built into the kernel image (CONFIG_REISERFS=y),
CONFIG_CRC32 also needs to be =y.
Probably just add
select CRC32
select BITREVERSE
to the REISERFS_FS kconfig entry.

> BTW, from series file of mmotm, I see two version patches,
> fs-reiserfs-return-f_fsid-for-statfs2.patch
> fs-reiserfs-return-f_fsid-for-statfs2-v2.patch
> are all included. I suspect whether this is a proper behavior.

The v2 patch mostly replaces the first one. I don't see a
problem with them.

--
~Randy