public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -tip 1/3] x86, mce: Add mce_threshold option for intel cmci
Date: Thu, 26 Mar 2009 10:10:15 +0100	[thread overview]
Message-ID: <49CB4677.9010403@linux.intel.com> (raw)
In-Reply-To: <49CB3F24.8040804@jp.fujitsu.com>

Hidetoshi Seto wrote:
> This patch adds a kernel parameter "mce_threshold=n" to enable us
> to change the default threshold for CMCI(Corrected Machine Check
> Interrupt) that recent Intel processor supports.

I intentionally didn't implement this because it seemed not needed.

Any threshold in the actual error reporting should be implemented
in the user space processing backend, but not in the CPU, because
they typically need to be more fine grained than just per bank,
and the CPU cannot do that.

The only potential reason for implementing this threshold at the
CPU level is if someone is concerned about CPU consumption during error storms.
But then the threshold should be dynamically adjusted based on the
current rate, otherwise it doesn't help.

But I didn't do this so far because I didn't want to overengineer
and in general if you have a error storm you're likely soon dead
anyways.

Also even if this was implemented a boot option would seem
like the wrong interface compared to sysfs.

Can you please describe your rationale for this more clearly?

-Andi


  reply	other threads:[~2009-03-26  9:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26  8:39 [PATCH -tip 1/3] x86, mce: Add mce_threshold option for intel cmci Hidetoshi Seto
2009-03-26  9:10 ` Andi Kleen [this message]
2009-03-27  9:44   ` Hidetoshi Seto
2009-03-27 10:31     ` Andi Kleen
2009-03-30  9:06       ` Hidetoshi Seto
2009-03-30 10:05         ` Andi Kleen
2009-03-31  7:22           ` Hidetoshi Seto
2009-03-31  8:15             ` Andi Kleen
2009-03-28 12:00     ` Ingo Molnar
2009-03-28 12:08 ` Ingo Molnar
2009-03-30  9:42   ` Andi Kleen
2009-03-31  2:45     ` Hidetoshi Seto
2009-03-31  8:08       ` Andi Kleen
2009-03-31  2:45   ` Hidetoshi Seto
2009-04-01 15:07     ` Ingo Molnar
2009-04-02  4:43       ` Hidetoshi Seto
2009-04-02  4:54         ` [PATCH -tip 1/3] x86, mce: Revert "add mce_threshold option for intel cmci" Hidetoshi Seto
2009-04-02  4:55         ` [PATCH -tip 2/3] x86, mce: Revert "add mce=nopoll option to disable timer polling" Hidetoshi Seto
2009-04-02  4:58         ` [PATCH -tip 3/3] x86, mce: Add new option mce=no_cmci and mce=ignore_ce Hidetoshi Seto
2009-03-28 21:28 ` [tip:x86/mce2] x86, mce: Add mce_threshold option for intel cmci Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CB4677.9010403@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox