From: Benny Halevy <bhalevy@panasas.com>
To: pNFS Mailing List <pnfs@linux-nfs.org>
Cc: Fredric Isaman <iisaman@citi.umich.edu>,
Steve Dickson <steved@redhat.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] lib: statically link find_last_bit
Date: Thu, 26 Mar 2009 13:23:03 +0200 [thread overview]
Message-ID: <49CB6597.9060607@panasas.com> (raw)
Currently, the only use of find_last_bit in the kernel is
setup_nr_cpu_ids which compiles only under CONFIG_SMP.
On uniprocessor machines the linker can't find it when
needed in a loadable module.
Kernel: arch/x86/boot/bzImage is ready (#5)
Building modules, stage 2.
MODPOST 515 modules
ERROR: "find_last_bit" [fs/nfs/nfs.ko] undefined!
Cc: Fredric Isaman <iisaman@citi.umich.edu>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
patch required for the nfs41 series
lib/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/Makefile b/lib/Makefile
index 32b0e64..286e2f7 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -37,7 +37,7 @@ lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o
lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
lib-$(CONFIG_GENERIC_FIND_FIRST_BIT) += find_next_bit.o
lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
-lib-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
+obj-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
obj-$(CONFIG_PLIST) += plist.o
--
1.6.2.1
reply other threads:[~2009-03-26 11:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CB6597.9060607@panasas.com \
--to=bhalevy@panasas.com \
--cc=iisaman@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox