Re: [PATCH -tip] x86: move vmware to hypervisor

Jaswinder Singh Rajput
2009-03-25T17:08:02Z

On Wed, 2009-03-25 at 09:52 -0700, Alok Kataria wrote:
> >
> > vmware can be considered a CPU here, so i think making the disabling
> > also depend on PROCESSOR_SELECT.
>
> Ingo, this code is not just to be used by VMware, the reason we did this
> generically was so that a guest could run unaltered on *any* fully
> virtualized hypervisor.
> And give that this code is just a boot setup thing, the only thing this
> patch saves over here is not running the detection code on native
> systems. All the rest of the code is guarded by the
> "boot_cpu_data.x86_hyper_vendor" checks anyways.
>
> I don't really see the point of adding one more config option just for
> this.
>

Can you please explain what is the point of adding this support all the
time if this is useless for 99.9% of cases. IMHO, it should be optional.

--
JSR