From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/7] blktrace: make classic output more classic
Date: Fri, 27 Mar 2009 13:40:29 +0800 [thread overview]
Message-ID: <49CC66CD.1050002@cn.fujitsu.com> (raw)
In-Reply-To: <49CC6691.7050103@cn.fujitsu.com>
In the classic user-space blktrace, the output timestamp is sec.nsec
not sec.usec.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/trace/blktrace.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index d43cdac..5b28f0f 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -994,8 +994,8 @@ static void get_pdu_remap(const struct trace_entry *ent,
static int blk_log_action_iter(struct trace_iterator *iter, const char *act)
{
char rwbs[6];
- unsigned long long ts = ns2usecs(iter->ts);
- unsigned long usec_rem = do_div(ts, USEC_PER_SEC);
+ unsigned long long ts = iter->ts;
+ unsigned long nsec_rem = do_div(ts, NSEC_PER_SEC);
unsigned secs = (unsigned long)ts;
const struct trace_entry *ent = iter->ent;
const struct blk_io_trace *t = (const struct blk_io_trace *)ent;
@@ -1003,9 +1003,9 @@ static int blk_log_action_iter(struct trace_iterator *iter, const char *act)
fill_rwbs(rwbs, t);
return trace_seq_printf(&iter->seq,
- "%3d,%-3d %2d %5d.%06lu %5u %2s %3s ",
+ "%3d,%-3d %2d %5d.%09lu %5u %2s %3s ",
MAJOR(t->device), MINOR(t->device), iter->cpu,
- secs, usec_rem, ent->pid, act, rwbs);
+ secs, nsec_rem, ent->pid, act, rwbs);
}
static int blk_log_action_seq(struct trace_seq *s, const struct blk_io_trace *t,
--
1.5.4.rc3
next prev parent reply other threads:[~2009-03-27 5:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 5:39 [PATCH v2 0/7] blktrace: last round of fixes Li Zefan
2009-03-27 5:39 ` [PATCH v2 1/7] trace: make 'mem' argument of trace_seq_putmem() const Li Zefan
2009-03-27 5:40 ` Li Zefan [this message]
2009-03-27 5:40 ` [PATCH v2 3/7] blktrace: fix blk_probes_ref chaos Li Zefan
2009-03-27 8:13 ` [PATCH v3 " Li Zefan
2009-03-27 5:40 ` [PATCH v2 4/7] blktrace: fix memory leak when freeing struct blk_io_trace Li Zefan
2009-03-27 8:13 ` [PATCH v3 " Li Zefan
2009-03-27 5:41 ` [PATCH v2 5/7] blktrace: extract duplidate code Li Zefan
2009-03-27 5:41 ` [PATCH v2 6/7] blktrace: print out BLK_TN_MESSAGE properly Li Zefan
2009-03-27 5:42 ` [PATCH v2 7/7] blktrace: support filtering of BLK_TN_MESSAGE Li Zefan
2009-03-27 9:42 ` [PATCH v2 0/7] blktrace: last round of fixes Ingo Molnar
2009-03-28 22:46 ` Ingo Molnar
2009-03-29 18:02 ` Jens Axboe
2009-03-30 1:17 ` Ingo Molnar
2009-03-30 0:40 ` Li Zefan
2009-03-30 1:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CC66CD.1050002@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox