From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -tip 2/3] x86, mce: Cleanup param parser
Date: Fri, 27 Mar 2009 18:45:13 +0900 [thread overview]
Message-ID: <49CCA029.40400@jp.fujitsu.com> (raw)
In-Reply-To: <49CB4C7B.8080401@linux.intel.com>
Andi Kleen wrote:
> Hidetoshi Seto wrote:
>> - Fix the comment formatting.
>> - The error path does not return 0, and printk lacks level and "\n".
>> - Move __setup("nomce") next to mcheck_disable().
>> - Improve readability etc.
>
> Looks good.
Thank you for reviewing!
This cleanup can stand alone, so could you apply this onto -tip?
# Or would you request me to resend it with subject stripped "2/3"?
Thanks,
H.Seto
next prev parent reply other threads:[~2009-03-27 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 8:39 [PATCH -tip 2/3] x86, mce: Cleanup param parser Hidetoshi Seto
2009-03-26 9:35 ` Andi Kleen
2009-03-27 9:45 ` Hidetoshi Seto [this message]
2009-03-27 11:34 ` Andi Kleen
2009-03-28 21:29 ` [tip:x86/mce2] " Hidetoshi Seto
2009-05-29 18:54 ` [tip:x86/mce3] " tip-bot for Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CCA029.40400@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox