* [PATCH] xen/balloon: remove a warning.
@ 2009-03-27 6:14 Isaku Yamahata
2009-03-27 16:50 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 2+ messages in thread
From: Isaku Yamahata @ 2009-03-27 6:14 UTC (permalink / raw)
To: jeremy; +Cc: linux-kernel, xen-devel
This patch removes the following warning on ia64.
drivers/xen/balloon.c: In function 'show_target':
drivers/xen/balloon.c:516: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
drivers/xen/balloon.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index efa4b36..b989ba6 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -513,7 +513,8 @@ static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr
char *buf)
{
return sprintf(buf, "%llu\n",
- (u64)balloon_stats.target_pages << PAGE_SHIFT);
+ (unsigned long long)balloon_stats.target_pages <<
+ PAGE_SHIFT);
}
static ssize_t store_target(struct sys_device *dev,
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xen/balloon: remove a warning.
2009-03-27 6:14 [PATCH] xen/balloon: remove a warning Isaku Yamahata
@ 2009-03-27 16:50 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2009-03-27 16:50 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: linux-kernel, xen-devel
Isaku Yamahata wrote:
> This patch removes the following warning on ia64.
>
> drivers/xen/balloon.c: In function 'show_target':
> drivers/xen/balloon.c:516: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
>
Ah, the old long vs long long u64 bites again. OK.
J
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> drivers/xen/balloon.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index efa4b36..b989ba6 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -513,7 +513,8 @@ static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr
> char *buf)
> {
> return sprintf(buf, "%llu\n",
> - (u64)balloon_stats.target_pages << PAGE_SHIFT);
> + (unsigned long long)balloon_stats.target_pages <<
> + PAGE_SHIFT);
> }
>
> static ssize_t store_target(struct sys_device *dev,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-27 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-27 6:14 [PATCH] xen/balloon: remove a warning Isaku Yamahata
2009-03-27 16:50 ` Jeremy Fitzhardinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox