public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Chris Leech <christopher.leech@intel.com>, Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] irq: mask irq before move it
Date: Fri, 27 Mar 2009 21:43:01 -0700	[thread overview]
Message-ID: <49CDAAD5.9010202@kernel.org> (raw)
In-Reply-To: <20090327163438.GA10185@cleech-lnx.jf.intel.com>


Imapct: fix panic

try to mask the irq, before move the irq desc

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 kernel/irq/numa_migrate.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-2.6/kernel/irq/numa_migrate.c
===================================================================
--- linux-2.6.orig/kernel/irq/numa_migrate.c
+++ linux-2.6/kernel/irq/numa_migrate.c
@@ -112,17 +112,21 @@ struct irq_desc *move_irq_desc(struct ir
 {
 	int old_cpu;
 	int node, old_node;
+	unsigned int irq = desc->irq;
 
 	/* those all static, do move them */
-	if (desc->irq < NR_IRQS_LEGACY)
+	if (irq < NR_IRQS_LEGACY)
 		return desc;
 
 	old_cpu = desc->cpu;
 	if (old_cpu != cpu) {
 		node = cpu_to_node(cpu);
 		old_node = cpu_to_node(old_cpu);
-		if (old_node != node)
+		if (old_node != node) {
+			desc->chip->mask(irq);
 			desc = __real_move_irq_desc(desc, cpu);
+			desc->chip->unmask(irq);
+		}
 		else
 			desc->cpu = cpu;
 	}

  parent reply	other threads:[~2009-03-28  4:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 22:04 2.6.29 bug with SPARSE_IRQ + NUMA_MIGRATE_IRQ_DESC Chris Leech
     [not found] ` <86802c440903261929s775fe85cv86b900e2610acf1d@mail.gmail.com>
     [not found]   ` <20090327163438.GA10185@cleech-lnx.jf.intel.com>
2009-03-28  4:43     ` Yinghai Lu [this message]
2009-03-30 22:09       ` [PATCH] irq: mask irq before move it Chris Leech
2009-03-30 22:10       ` Chris Leech
2009-03-30 22:25         ` Yinghai Lu
2009-03-30 22:56           ` Chris Leech
2009-03-31  1:53             ` Chris Leech
2009-03-31 13:19         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CDAAD5.9010202@kernel.org \
    --to=yinghai@kernel.org \
    --cc=christopher.leech@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox