From: Brice Goglin <Brice.Goglin@inria.fr>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Eric Anholt <eric@anholt.net>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: DRM lock ordering fix series
Date: Sat, 28 Mar 2009 09:46:57 +0100 [thread overview]
Message-ID: <49CDE401.2020502@inria.fr> (raw)
In-Reply-To: <1238201922.4039.403.camel@laptop>
Peter Zijlstra wrote:
> Also note that doing large gup() with gup_fast() will be undesirable due
> to it disabling IRQs. So iterating say several MB worth of pages will
> hurt like crazy. Currently all gup_fast() users do a single page lookup.
>
In 2.6.29, fs/bio.c:955, fs/direct-io.c:153 and fs/splice.c:1222 do
multiple-pages lookup at once. The latter might be limited to 16 pages
because of the pipe-depth, I don't know about the formers.
Is there some sort of reasonable limit? A couple dozens pages at once maybe?
Brice
next prev parent reply other threads:[~2009-03-28 9:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 21:45 DRM lock ordering fix series Eric Anholt
2009-03-25 21:45 ` [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path Eric Anholt
2009-03-25 21:45 ` [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free Eric Anholt
2009-03-25 21:45 ` [PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path Eric Anholt
2009-03-25 21:45 ` [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path Eric Anholt
2009-03-25 21:45 ` [PATCH 5/6] drm/i915: Fix lock order reversal with cliprects and cmdbuf in non-DRI2 paths Eric Anholt
2009-03-25 21:45 ` [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation entry copying Eric Anholt
2009-03-30 10:00 ` [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation entry copying. -- makes X hang Florian Mickler
2009-03-31 19:36 ` Eric Anholt
2009-04-01 0:12 ` Florian Mickler
2009-03-27 0:52 ` [PATCH 5/6] drm/i915: Fix lock order reversal with cliprects and cmdbuf in non-DRI2 paths Jesse Barnes
2009-03-25 23:30 ` [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path Dave Airlie
2009-03-26 4:03 ` Keith Packard
2009-03-27 0:50 ` Jesse Barnes
2009-03-27 0:50 ` [PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path Jesse Barnes
2009-03-25 22:52 ` [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free Dave Airlie
2009-03-26 19:59 ` Eric Anholt
2009-03-27 0:47 ` Jesse Barnes
2009-03-27 0:43 ` [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path Jesse Barnes
2009-03-27 16:56 ` Eric Anholt
2009-03-27 17:07 ` Jesse Barnes
2009-03-28 0:54 ` Peter Zijlstra
2009-03-28 2:35 ` Jesse Barnes
2009-03-28 5:22 ` Dave Airlie
2009-03-27 9:34 ` DRM lock ordering fix series Andi Kleen
2009-03-27 16:19 ` Eric Anholt
2009-03-27 16:36 ` Eric Anholt
2009-03-27 18:10 ` Andi Kleen
2009-03-27 20:10 ` Eric Anholt
2009-03-27 21:05 ` Andi Kleen
2009-03-28 0:58 ` Peter Zijlstra
2009-03-28 1:29 ` Peter Zijlstra
2009-03-30 6:29 ` Eric Anholt
2009-03-28 8:46 ` Brice Goglin [this message]
2009-03-28 10:48 ` Peter Zijlstra
2009-03-28 12:22 ` [RFC] x86: gup_fast() batch limit (was: DRM lock ordering fix series) Peter Zijlstra
2009-03-28 12:46 ` Peter Zijlstra
2009-04-02 11:19 ` Nick Piggin
2009-06-24 13:46 ` [RFC] x86: gup_fast() batch limit Brice Goglin
2009-06-24 17:07 ` Peter Zijlstra
2009-06-24 19:55 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CDE401.2020502@inria.fr \
--to=brice.goglin@inria.fr \
--cc=andi@firstfloor.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox