From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756873AbZC2MCE (ORCPT ); Sun, 29 Mar 2009 08:02:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755780AbZC2MBv (ORCPT ); Sun, 29 Mar 2009 08:01:51 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39597 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755424AbZC2MBu (ORCPT ); Sun, 29 Mar 2009 08:01:50 -0400 Message-ID: <49CF632A.7070906@redhat.com> Date: Sun, 29 Mar 2009 15:01:46 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Marcelo Tosatti CC: Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] Support for GB pages in KVM References: <1238164319-16092-1-git-send-email-joerg.roedel@amd.com> <20090328214008.GB4694@amt.cnet> In-Reply-To: <20090328214008.GB4694@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marcelo Tosatti wrote: > On Fri, Mar 27, 2009 at 03:31:52PM +0100, Joerg Roedel wrote: > >> Hi, >> >> this patchset extends the KVM MMU implementation to support 1GB pages as >> supported by AMD family 16 processors. These patches enable support for >> 1 GB pages with Nested Paging. Support for these pages in the shadow >> paging code was also developed but does not run stable yet. The patch >> for shadow-paging support is not included in this series and will be >> sent out seperatly. >> > > Looks generally sane. I'm not sure its even worthwhile to support > GBpages with softmmu, because the chance of finding an area without > shadowed (write protected) pages is much smaller than with 2MB pages. > If the guest uses 1GB pages in userspace, then these pages would not have any write protected subpages. -- error compiling committee.c: too many arguments to function