From: Patrick McHardy <kaber@trash.net>
To: Roman Mindalev <r000n@r000n.net>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
Stephen Hemminger <shemminger@vyatta.com>,
LKML <linux-kernel@vger.kernel.org>,
netfilter@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Regression caused by commit "netfilter: iptables: lock free counters"
Date: Mon, 30 Mar 2009 14:08:08 +0200 [thread overview]
Message-ID: <49D0B628.5000501@trash.net> (raw)
In-Reply-To: <20090330145031.2dfd854e@desktop.r000n.info>
Roman Mindalev wrote:
> On Mon, 30 Mar 2009 09:32:51 +0200
> Eric Dumazet <dada1@cosmosbay.com> wrote:
>
>> Could you try following patch ?
>>
>> [PATCH] netfilter: use rcu_read_bh() in ipt_do_table()
>>
>> Commit 784544739a25c30637397ace5489eeb6e15d7d49
>> (netfilter: iptables: lock free counters) forgot to disable BH
>> in arpt_do_table(), ipt_do_table() and ip6t_do_table()
>>
>> Use rcu_read_lock_bh() instead of rcu_read_lock() cures the problem.
>>
>> Reported-and-bisected-by: Roman Mindalev <r000n@r000n.net>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>> ---
>
> 2.6.29-git4 and 2.6.29-git6 both works fine for me with this patch.
> Thanks, Eric!
Thanks indeed Eric :) Dave, please apply.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2009-03-30 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 19:47 Regression caused by commit "netfilter: iptables: lock free counters" Roman Mindalev
2009-03-30 7:32 ` Eric Dumazet
2009-03-30 10:50 ` Roman Mindalev
2009-03-30 12:08 ` Patrick McHardy [this message]
2009-03-30 14:56 ` Stephen Hemminger
2009-04-02 7:54 ` David Miller
2009-03-30 12:06 ` Patrick McHardy
2009-04-05 7:05 ` Graham Murray
2009-04-05 8:22 ` David Miller
2009-04-05 10:01 ` Eric Dumazet
2009-04-05 10:12 ` Graham Murray
2009-04-05 10:30 ` Eric Dumazet
2009-04-05 12:29 ` [PATCH] netfilter: ip6tables fix Eric Dumazet
2009-04-05 12:40 ` Eric Dumazet
2009-04-06 15:08 ` Patrick McHardy
2009-04-05 11:36 ` Regression caused by commit "netfilter: iptables: lock free counters" Jan Engelhardt
2009-04-05 12:34 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D0B628.5000501@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=r000n@r000n.net \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox