public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: ivtv-devel@ivtvdriver.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	v4l-dvb-maintainer@linuxtv.org, g.liakhovetski@gmx.de,
	video4linux-list@redhat.com
Subject: Re: [ivtv-devel] 2.6.29: ivtv-vbi.c: divide-by-zero in compress_sliced_buf()
Date: Mon, 30 Mar 2009 09:32:33 -0400	[thread overview]
Message-ID: <49D0C9F1.6020006@rtr.ca> (raw)
In-Reply-To: <49D0C936.8090407@rtr.ca>

Mark Lord wrote:
> Hans Verkuil wrote:
>> On Monday 30 March 2009 04:59:34 Mark Lord wrote:
>>> The changes to line_size in 2.6.29 now cause
>>> attempts to record from my PVR250 cards (MythTV)
>>> to die with a divide by zero error in ivtv-vbi.c.
>>>
>>> The value of "line_size" in compress_sliced_buf() is zero.
>>
>> Weird. That should never be zero. Can you mail me the ivtv 
>> initialization log from dmesg? I need the bit between 'ivtv: Start 
>> initialization' and 'ivtv: End initialization'.
> ..
> 
> Sent.
..

For what it's worth, I did try patching that function to detect
a line_size of zero, and replace it on the fly with a more likely value.
This prevented the crash, but the recorded video was very dark, as if
colour controls had not be initialized.  That could be another clue.

Cheers

  reply	other threads:[~2009-03-30 13:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  2:59 2.6.29: ivtv-vbi.c: divide-by-zero in compress_sliced_buf() Mark Lord
2009-03-30  9:00 ` [ivtv-devel] " Hans Verkuil
2009-03-30 13:29   ` Mark Lord
2009-03-30 13:32     ` Mark Lord [this message]
2009-03-30 16:21   ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D0C9F1.6020006@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox