Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supports arguments

[Masami Hiramatsu <mhiramat@redhat.com>]

Ananth N Mavinakayanahalli wrote:
> On Thu, Mar 26, 2009 at 06:59:30PM -0400, Masami Hiramatsu wrote:
> 
>> +/* TODO: Move these functions to arch/XXX/include/asm/debugger.h */
>> +
> 
> Maybe arch/xxx/lib/<>.c too?
> 
> I know its on your list of TODOs but I'd prefer to have an
> arch_fetch_func_args() or somesuch in arch specific code, to start with.
> It is trivial to implement the argument extraction code on certain
> architectures and such a helper would be great.

Hmm, I think fetch_* functions are more general framework, but
it's true that some of their implementation depend on architecture.
Thus, I'd prefer to separate some of basic implementaions(get_stack_nth,
get_argument_nth) from fetch_* and move it to arch/xxx/include/asm/ptrace.h,
because there are similar inline functions.
What would you think about this?

Thank you!

> 
> Ananth

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com