From: Jeff Mahoney <jeffm@suse.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
ReiserFS Development List <reiserfs-devel@vger.kernel.org>
Subject: Re: [PATCH] reiserfs: fix build breakage
Date: Mon, 30 Mar 2009 16:45:31 -0400 [thread overview]
Message-ID: <49D12F6B.6060408@suse.com> (raw)
In-Reply-To: <20090330203240.GA19456@orion>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Beregalov wrote:
> fs/reiserfs/inode.c: In function 'reiserfs_new_inode':
> fs/reiserfs/inode.c:1919: warning: passing argument 1 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: warning: passing argument 2 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: warning: passing argument 3 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: error: too many arguments to function
> 'reiserfs_inherit_default_acl'
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> include/linux/reiserfs_acl.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/reiserfs_acl.h b/include/linux/reiserfs_acl.h
> index 52240e0..8cc6575 100644
> --- a/include/linux/reiserfs_acl.h
> +++ b/include/linux/reiserfs_acl.h
> @@ -80,7 +80,8 @@ static inline int reiserfs_acl_chmod(struct inode *inode)
> }
>
> static inline int
> -reiserfs_inherit_default_acl(const struct inode *dir, struct dentry *dentry,
> +reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
> + const struct inode *dir, struct dentry *dentry,
> struct inode *inode)
> {
> return 0;
Acked-by: Jeff Mahoney <jeffm@suse.com>
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iEYEARECAAYFAknRL2sACgkQLPWxlyuTD7KPRQCeKLggyevsf27KTS+CujDnR23G
2XoAnRqE0fO0PAbqmL1DSXwK3HhRxQ+2
=ed4M
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2009-03-30 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 20:32 [PATCH] reiserfs: fix build breakage Alexander Beregalov
2009-03-30 20:45 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D12F6B.6060408@suse.com \
--to=jeffm@suse.com \
--cc=a.beregalov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox