From: Witold Szczeponik <Witold.Szczeponik@gmx.net>
To: yakui_zhao <yakui.zhao@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bjorn.helgaas@hp.com" <bjorn.helgaas@hp.com>,
"abelay@mit.edu" <abelay@mit.edu>, "rjw@sisk.pl" <rjw@sisk.pl>
Subject: Re: [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3
Date: Tue, 31 Mar 2009 22:37:23 +0200 [thread overview]
Message-ID: <49D27F03.2070302@gmx.net> (raw)
In-Reply-To: <1238463939.3625.99.camel@localhost.localdomain>
yakui_zhao wrote:
> Very good patch.
> Do you have the hardware on which the dedicated power source is
> required by the serial port(PnP device) in your hand?
>
Yes, I have an IBM ThinkPad 600E. I need this patch in order to
be able receive accurate time using a DCF77 receiver attached
to the serial port.
[snip]
>> - if (ACPI_FAILURE(status))
>> + if (ACPI_FAILURE(acpi_set_current_resources(handle, &buffer)))
>> ret = -EINVAL;
>> + else if (acpi_bus_power_manageable(handle))
>> + ret = acpi_bus_set_power(handle, ACPI_STATE_D0);
> How about changing the power state before calling _SRS object?
I recall reading something in the ACPI spec that says that the power
needs to be set after the device was enabled. But the main driver
for this order (_SRS followed by _PS0) is the symmetry to the required
_PS3 followed by _DIS (according to the spec).
[snip]
--- Witold
next prev parent reply other threads:[~2009-03-31 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 17:31 [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3 Witold Szczeponik
2009-03-31 1:45 ` yakui_zhao
2009-03-31 20:37 ` Witold Szczeponik [this message]
2009-03-31 10:19 ` Henrique de Moraes Holschuh
2009-04-04 1:32 ` Len Brown
2009-04-04 1:49 ` Len Brown
[not found] ` <200904021510.37517.trenn@suse.de>
2009-06-30 23:03 ` [stable] " Greg KH
2009-07-07 20:06 ` Witold Szczeponik
2009-07-28 19:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D27F03.2070302@gmx.net \
--to=witold.szczeponik@gmx.net \
--cc=abelay@mit.edu \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox