public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Corey Ashford <cjashfor@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: perf_counter: request for three more sample data options
Date: Thu, 02 Apr 2009 18:46:38 -0700	[thread overview]
Message-ID: <49D56A7E.80908@linux.vnet.ibm.com> (raw)

Currently, perf_counter has the ability to record the following on event 
counter overflow:

Instruction Pointer
Call chain
Group counter values
Thread id

To give perf_counter similar capabilities to perfmon2's default sampling 
  module, I'd like the following additional sample data to be added.

Time stamp
CPU number
Thread Group Id

I'd suggest the following

enum perf_counter_record_format {
         PERF_RECORD_IP          = 1U << 0,
         PERF_RECORD_TID         = 1U << 1,
         PERF_RECORD_TGID        = 1U << 2,
-        PERF_RECORD_GROUP       = 1U << 2,
+        PERF_RECORD_GROUP       = 1U << 3,
-        PERF_RECORD_CALLCHAIN   = 1U << 3,
+        PERF_RECORD_CALLCHAIN   = 1U << 4,
+        PERF_RECORD_CPU_ID      = 1U << 5,
+        PERF_RECORD_TIMESTAMP   = 1U << 6,
};

And of course the obvious changes to perf_event_type.

I would expect that CPU ID would be 32 bits, and the timestamp to be the 
64-bit current time.  TGID is the same size as TID.

I am guessing the only difficult thing here would be obtaining the 
current time from an IRQ, especially NMI handler.  Is this difficult?


-- 
Regards,

- Corey

Corey Ashford
Software Engineer
IBM Linux Technology Center, Linux Toolchain
Beaverton, OR
503-578-3507
cjashfor@us.ibm.com


             reply	other threads:[~2009-04-03  1:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03  1:46 Corey Ashford [this message]
2009-04-03  7:01 ` perf_counter: request for three more sample data options Peter Zijlstra
2009-04-03  7:25   ` Corey Ashford
2009-04-03  7:51     ` Peter Zijlstra
2009-04-03  8:51       ` Paul Mackerras
2009-04-03 16:38         ` Robert Richter
2009-04-03 16:41           ` Ingo Molnar
2009-04-03 16:59             ` Peter Zijlstra
2009-04-03 17:05               ` Ingo Molnar
2009-04-03 16:32       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D56A7E.80908@linux.vnet.ibm.com \
    --to=cjashfor@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox