From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Ingo Molnar <mingo@elte.hu>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Mel Gorman <mel@csn.ul.ie>, Jason Baron <jbaron@redhat.com>,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
alexn@dsv.su.se, akpm@linux-foundation.org, alexn@telia.com,
apw@shadowen.org, cl@linux-foundation.org, haveblue@us.ibm.com,
kamezawa.hiroyu@jp.fujitu.com,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
"Fr?d?ric Weisbecker" <fweisbec@gmail.com>
Subject: Re: + page-owner-tracking.patch added to -mm tree
Date: Fri, 03 Apr 2009 17:36:57 +0300 [thread overview]
Message-ID: <49D61F09.2080808@cs.helsinki.fi> (raw)
In-Reply-To: <20090403141743.GF8875@elte.hu>
Ingo Molnar wrote:
> * Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:
>
>> One thing I'm not sure about this patch is whether it manages to
>> record an allocation only once, i.e. does it log a single event
>> when/if the slab allocator requests pages? Some time ago I sent a
>> patch adding GFP_NOTRACE to gfp.h, but was rejected. Maybe this
>> could be a way out of the mess.
>>
>> (GFP_NOTRACE would also allow us to log "backend" allocations
>> easily and treat them separately, for the record, or simply filter
>> them out.)
>
> makes a lot of sense IMO to annotate these via a GFP flag.
Yup, make sense. I think I rejected the patch (did I?) because I wanted
to fix the slub/slab mess differently but here it makes perfect sense.
Pekka
next prev parent reply other threads:[~2009-04-03 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903312321.n2VNLAMI006236@imap1.linux-foundation.org>
2009-04-01 11:15 ` + page-owner-tracking.patch added to -mm tree Ingo Molnar
2009-04-01 12:55 ` Mel Gorman
2009-04-01 13:17 ` Ingo Molnar
2009-04-01 13:32 ` Mel Gorman
2009-04-01 13:49 ` Ingo Molnar
2009-04-01 14:49 ` Pekka Enberg
2009-04-01 15:22 ` Ingo Molnar
2009-04-02 7:12 ` Pekka Enberg
2009-04-03 4:21 ` Eduard - Gabriel Munteanu
2009-04-03 14:17 ` Ingo Molnar
2009-04-03 14:36 ` Pekka Enberg [this message]
2009-04-03 14:43 ` Ingo Molnar
2009-04-04 14:08 ` Eduard - Gabriel Munteanu
2009-04-06 7:12 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D61F09.2080808@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alexn@dsv.su.se \
--cc=alexn@telia.com \
--cc=apw@shadowen.org \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=fweisbec@gmail.com \
--cc=haveblue@us.ibm.com \
--cc=jbaron@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox