public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: add fiemap.h to header-y
Date: Fri, 03 Apr 2009 10:00:57 -0500	[thread overview]
Message-ID: <49D624A9.1040002@redhat.com> (raw)
In-Reply-To: <20090403064640.GA13075@uranus.ravnborg.org>

Sam Ravnborg wrote:

>> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
>> index a67b622..ca9b9b9 100644
>> --- a/include/linux/Kbuild
>> +++ b/include/linux/Kbuild
>> @@ -67,6 +67,7 @@ header-y += falloc.h
>>  header-y += fd.h
>>  header-y += fdreg.h
>>  header-y += fib_rules.h
>> +header-y += fiemap.h
>>  header-y += firewire-cdev.h
>>  header-y += firewire-constants.h
>>  header-y += fuse.h
> 
> Before adding a new headers as an exported headers please fix it up.
> This headers uses __u32/__u64 but fails to include <linux/types.h>
> 
> 	Sam

Sam -

Whoops, thanks for catching that.  Will take a look & submit a patch.

Thanks,

-Eric

      reply	other threads:[~2009-04-03 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904030459.n334xVpS019935@hera.kernel.org>
2009-04-03  6:46 ` add fiemap.h to header-y Sam Ravnborg
2009-04-03 15:00   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D624A9.1040002@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox