Re: add fiemap.h to header-y

Re: add fiemap.h to header-y

[Sam Ravnborg]

On Fri, Apr 03, 2009 at 04:59:31AM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/linus/8e2c3795c78d5c4e2e1f14ce751e9d08decbe9d3
> Commit:     8e2c3795c78d5c4e2e1f14ce751e9d08decbe9d3
> Parent:     c90bfeb80f00c765a57f17442fea1a57756b9034
> Author:     Eric Sandeen <sandeen@redhat.com>
> AuthorDate: Thu Apr 2 16:56:44 2009 -0700
> Committer:  Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Thu Apr 2 19:04:49 2009 -0700
> 
>     add fiemap.h to header-y
>     
>     Include fiemap.h in header-y; it defines the interface for the
>     FS_IOC_FIEMAP file mapping ioctl.
>     
>     Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>  include/linux/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index a67b622..ca9b9b9 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -67,6 +67,7 @@ header-y += falloc.h
>  header-y += fd.h
>  header-y += fdreg.h
>  header-y += fib_rules.h
> +header-y += fiemap.h
>  header-y += firewire-cdev.h
>  header-y += firewire-constants.h
>  header-y += fuse.h

Before adding a new headers as an exported headers please fix it up.
This headers uses __u32/__u64 but fails to include <linux/types.h>

	Sam

Re: add fiemap.h to header-y

[Eric Sandeen]

Sam Ravnborg wrote:

>> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
>> index a67b622..ca9b9b9 100644
>> --- a/include/linux/Kbuild
>> +++ b/include/linux/Kbuild
>> @@ -67,6 +67,7 @@ header-y += falloc.h
>>  header-y += fd.h
>>  header-y += fdreg.h
>>  header-y += fib_rules.h
>> +header-y += fiemap.h
>>  header-y += firewire-cdev.h
>>  header-y += firewire-constants.h
>>  header-y += fuse.h
> 
> Before adding a new headers as an exported headers please fix it up.
> This headers uses __u32/__u64 but fails to include <linux/types.h>
> 
> 	Sam

Sam -

Whoops, thanks for catching that.  Will take a look & submit a patch.

Thanks,

-Eric