Re: Revert "gro: Fix legacy path napi_complete crash",

David Miller
2009-03-26T07:59:54Z

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 25 Mar 2009 20:08:40 +0800

> GRO: Disable GRO on legacy netif_rx path
>
> When I fixed the GRO crash in the legacy receive path I used
> napi_complete to replace __napi_complete. Unfortunately they're
> not the same when NETPOLL is enabled, which may result in us
> not calling __napi_complete at all.
>
> What's more, we really do need to keep the __napi_complete call
> within the IRQ-off section since in theory an IRQ can occur in
> between and fill up the backlog to the maximum, causing us to
> lock up.
>
> Since we can't seem to find a fix that works properly right now,
> this patch reverts all the GRO support from the netif_rx path.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, and will push to -stable.