Re: [PATCH 2/5] ext3: call blkdev_issue_flush on fsync()

Fernando Luis Vázquez Cao
2009-03-30T02:50:43Z

Jeff Garzik wrote:
> Fernando Luis Vázquez Cao wrote:
>> To ensure that bits are truly on-disk after an fsync or fdatasync, we
>> should force a disk flush explicitly when there is dirty data/metadata
>> and the journal didn't emit a write barrier (either because metadata is
>> not being synched or barriers are disabled).
>>
>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
>
> Your patches do not seem to propagate the issue-flush error code, even
> when it is easily available.

Oops... you are right. I will fix that.

Thanks!

- Fernando