Re: Revert "gro: Fix legacy path napi_complete crash",

Ingo Molnar
2009-03-26T09:26:19Z

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Wed, Mar 25, 2009 at 11:01:49PM +0100, Ingo Molnar wrote:
> >
> > Sure, can try that. Probably the best would be if you sent me a
> > combo patch with the precise patch you meant me to try (there were
> > several patches, i'm not sure which one is the 'previous' one) plus
> > the forcedeth debug enable change as well.
>
> Sure, here's the patch to do both.

> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index b8251e8..101e552 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -64,7 +64,7 @@
> #include <asm/uaccess.h>
> #include <asm/system.h>
>
> -#if 0
> +#if 1
> #define dprintk printk
> #else
> #define dprintk(x...) do { } while (0)

The box is not even able to boot up, so many messages are printed.

Ingo