Re: [PATCH 2/2] Make relatime default

Pavel Machek
2009-04-09T21:13:52Z

On Thu 2009-04-09 13:47:37, Linus Torvalds wrote:
>
>
> On Thu, 9 Apr 2009, Pavel Machek wrote:
> >
> > 'No changes of ABI in stable series?'
>
> (a) we don't have a stable series any more
> and
> (b) this isn't an abi change, it's a system management change.

Well, stat() syscall no longer returns sane value in st_atime, while
all the userland stayed the same; only kernel changed. I believe that
is ABI change.

> If you don't think we can make those, then I assume that you also claim
> that we can't do thigns like commit 1b5e62b42, which doubled the writeback
> dirty thresholds, or any of the things that changed how dirty accounting
> was done in the first place?

Writeback dirty thresholds will only change timing, that was not part
of ABI. st_atime field is.

> I would _love_ for distros to do the sane thing, but they don't. That's a
> fact.

But is this a way to do it? Are there maybe better ways?

a) Publicly call those distros broken?

b) Add nasty printk() to mount to force their attention?

bb) Add nasty printk() and mdelay(1000) to really force their
attention? :-)

c) Modify mount command to do the dirty work instead of changing
default in kernel?

[as mountflags are not passed as a string by sys_mount(), you
are creating pretty nasty situation for users; users with old
distro but new kernel will not be even able to get old
behaviour back w/o updating /sbin/mount. This would prevent
it].
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html