Re: Revert "gro: Fix legacy path napi_complete crash",

Ingo Molnar
2009-03-25T22:02:30Z

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Wed, Mar 25, 2009 at 01:20:46PM +0100, Ingo Molnar wrote:
> >
> > ok - i have started testing the delta below, on top of the plain
> > revert.

it's still fine btw, so:

Tested-by: Ingo Molnar <mingo@elte.hu>

> Thanks! BTW Ingo, any chance you could help us identify the
> problem with the previous patch? I don't have a forcedeth machine
> here and the hang you had with my patch that open-coded
> __napi_complete appears intimately connected to forcedeth (with
> NAPI enabled).
>
> The simplest thing to try would be to build forcedeth.c with DEBUG
> and see what it prints out after it locks up.

Sure, can try that. Probably the best would be if you sent me a
combo patch with the precise patch you meant me to try (there were
several patches, i'm not sure which one is the 'previous' one) plus
the forcedeth debug enable change as well.

Thanks,

Ingo