Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Larry Finger]

>On Tue, 2009-04-07 at 00:47 +0200, Rafael J. Wysocki wrote:
>> Hi,
>>
>> Current mainline (commit 22ae77bc7ac115b9d518d5cbc13d39317079b2b0) can't
>> find the root device (it's handled by statically compiled-in sata_sil) and
>> generally causes the "invalid module format" message to appear for all modules
>> loaded from the initrd on my HP nx6325 (the distro is openSUSE 11.1).
>>
>> I don't know which commit might have made this happen, but the breakage was
>> introduced during the last three days (commit
>> 601cc11d054ae4b5e9b5babec3d8e4667a2cb9b5 is certainly good). I'll bisect
>> tomorrow if there are no ideas.

> I bisected "invalid module format" woes to 9cb610d.

My system also fails to load modules from initrd unless 9cb610d is reverted.
Something is wrong with the "module: remove the SHF_ALLOC flag on the __versions
section" patch.

Larry

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Rafael J. Wysocki]

On Tuesday 07 April 2009, Larry Finger wrote:
> >On Tue, 2009-04-07 at 00:47 +0200, Rafael J. Wysocki wrote:
> >> Hi,
> >>
> >> Current mainline (commit 22ae77bc7ac115b9d518d5cbc13d39317079b2b0) can't
> >> find the root device (it's handled by statically compiled-in sata_sil) and
> >> generally causes the "invalid module format" message to appear for all modules
> >> loaded from the initrd on my HP nx6325 (the distro is openSUSE 11.1).
> >>
> >> I don't know which commit might have made this happen, but the breakage was
> >> introduced during the last three days (commit
> >> 601cc11d054ae4b5e9b5babec3d8e4667a2cb9b5 is certainly good). I'll bisect
> >> tomorrow if there are no ideas.
> 
> > I bisected "invalid module format" woes to 9cb610d.
> 
> My system also fails to load modules from initrd unless 9cb610d is reverted.
> Something is wrong with the "module: remove the SHF_ALLOC flag on the __versions
> section" patch.

This is fixed in the current -git, although I had to apply the patch from
http://patchwork.kernel.org/patch/16776/
to fix an Oops on boot.

Thanks,
Rafael

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Larry Finger]

Rafael J. Wysocki wrote:
> On Tuesday 07 April 2009, Larry Finger wrote:
>> My system also fails to load modules from initrd unless 9cb610d is reverted.
>> Something is wrong with the "module: remove the SHF_ALLOC flag on the __versions
>> section" patch.
> 
> This is fixed in the current -git, although I had to apply the patch from
> http://patchwork.kernel.org/patch/16776/
> to fix an Oops on boot.

Thanks for the heads-up, particularly on the 16776 patch above. I was in the
middle of a bisection to isolate that one.

Do you know anything about a regression that leads to "phy0: Failed to
initialize wep: -2" messages? It is the 3rd one that I'm chasing and seems to
affect all wireless drivers. For this one, removing and reinserting the driver
corrects the problem.

Larry

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Rafael J. Wysocki]

On Tuesday 07 April 2009, Larry Finger wrote:
> Rafael J. Wysocki wrote:
> > On Tuesday 07 April 2009, Larry Finger wrote:
> >> My system also fails to load modules from initrd unless 9cb610d is reverted.
> >> Something is wrong with the "module: remove the SHF_ALLOC flag on the __versions
> >> section" patch.
> > 
> > This is fixed in the current -git, although I had to apply the patch from
> > http://patchwork.kernel.org/patch/16776/
> > to fix an Oops on boot.
> 
> Thanks for the heads-up, particularly on the 16776 patch above. I was in the
> middle of a bisection to isolate that one.
> 
> Do you know anything about a regression that leads to "phy0: Failed to
> initialize wep: -2" messages? It is the 3rd one that I'm chasing and seems to
> affect all wireless drivers. For this one, removing and reinserting the driver
> corrects the problem.

No, I didn't know about this one.  Has it been reported anywhere already?

Rafael

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Larry Finger]

Rafael J. Wysocki wrote:
> On Tuesday 07 April 2009, Larry Finger wrote:
>>
>> Do you know anything about a regression that leads to "phy0: Failed to
>> initialize wep: -2" messages? It is the 3rd one that I'm chasing and seems to
>> affect all wireless drivers. For this one, removing and reinserting the driver
>> corrects the problem.
> 
> No, I didn't know about this one.  Has it been reported anywhere already?

Only on the wireless mail list. Once I get the bad commit, I'll post it in LKML.

Larry

Re: [2 regressions] Current git cannot find root device on x86-64(HP nx6325), NFS broken

[Rafael J. Wysocki]

On Tuesday 07 April 2009, Larry Finger wrote:
> Rafael J. Wysocki wrote:
> > On Tuesday 07 April 2009, Larry Finger wrote:
> >>
> >> Do you know anything about a regression that leads to "phy0: Failed to
> >> initialize wep: -2" messages? It is the 3rd one that I'm chasing and seems to
> >> affect all wireless drivers. For this one, removing and reinserting the driver
> >> corrects the problem.
> > 
> > No, I didn't know about this one.  Has it been reported anywhere already?
> 
> Only on the wireless mail list.

A pointer to the wireless mailing list thread would do too. :-)

> Once I get the bad commit, I'll post it in LKML.

OK, thanks.

Best,
Rafael

[2 regressions] Current git cannot find root device on x86-64 (HP nx6325), NFS broken

[Rafael J. Wysocki]

Hi,

Current mainline (commit 22ae77bc7ac115b9d518d5cbc13d39317079b2b0) can't
find the root device (it's handled by statically compiled-in sata_sil) and
generally causes the "invalid module format" message to appear for all modules
loaded from the initrd on my HP nx6325 (the distro is openSUSE 11.1).

I don't know which commit might have made this happen, but the breakage was
introduced during the last three days (commit
601cc11d054ae4b5e9b5babec3d8e4667a2cb9b5 is certainly good).  I'll bisect
tomorrow if there are no ideas.

Also, mounting directories over NFS doesn't work (I think it oopses, but
didn't have the time to look at it more closely).

Thanks,
Rafael

Re: [2 regressions] Current git cannot find root device on x86-64 (HP nx6325), NFS broken

[Trond Myklebust]

On Tue, 2009-04-07 at 00:47 +0200, Rafael J. Wysocki wrote:
> Also, mounting directories over NFS doesn't work (I think it oopses, but
> didn't have the time to look at it more closely).

There is a known double free issue that affects the 'proto=' mount
option (we call kfree(string) twice). Please could you check that the
following patch fixes it for you?

Cheers
  Trond

--------------------------------------------------------------------
>From a3e6cc62dce11c75249f01423eb9b41531759d36 Mon Sep 17 00:00:00 2001
From: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Mon, 6 Apr 2009 16:41:35 -0700
Subject: [PATCH] NFS: Fix a double free in nfs_parse_mount_options()

Due to an apparent typo, commit a67d18f89f5782806135aad4ee012ff78d45aae7
(NFS: load the rpc/rdma transport module automatically) lead to the
'proto=' mount option doing a double free, while Opt_mountproto leaks a
string.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
 fs/nfs/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 82eaadb..6717200 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1228,7 +1228,6 @@ static int nfs_parse_mount_options(char *raw,
 				goto out_nomem;
 			token = match_token(string,
 					    nfs_xprt_protocol_tokens, args);
-			kfree(string);
 
 			switch (token) {
 			case Opt_xprt_udp:
@@ -1258,6 +1257,7 @@ static int nfs_parse_mount_options(char *raw,
 				goto out_nomem;
 			token = match_token(string,
 					    nfs_xprt_protocol_tokens, args);
+			kfree(string);
 
 			switch (token) {
 			case Opt_xprt_udp:
-- 
1.6.0.4



-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

Re: [2 regressions] Current git cannot find root device on x86-64 (HP nx6325), NFS broken

[Rafael J. Wysocki]

On Tuesday 07 April 2009, Trond Myklebust wrote:
> On Tue, 2009-04-07 at 00:47 +0200, Rafael J. Wysocki wrote:
> > Also, mounting directories over NFS doesn't work (I think it oopses, but
> > didn't have the time to look at it more closely).
> 
> There is a known double free issue that affects the 'proto=' mount
> option (we call kfree(string) twice). Please could you check that the
> following patch fixes it for you?

The problem is fixed in the current -git, so I guess the patch is in there. :-)

Thanks,
Rafael

Re: [2 regressions] Current git cannot find root device on x86-64 (HP nx6325), NFS broken

[Mike Galbraith]

On Tue, 2009-04-07 at 00:47 +0200, Rafael J. Wysocki wrote:
> Hi,
> 
> Current mainline (commit 22ae77bc7ac115b9d518d5cbc13d39317079b2b0) can't
> find the root device (it's handled by statically compiled-in sata_sil) and
> generally causes the "invalid module format" message to appear for all modules
> loaded from the initrd on my HP nx6325 (the distro is openSUSE 11.1).
> 
> I don't know which commit might have made this happen, but the breakage was
> introduced during the last three days (commit
> 601cc11d054ae4b5e9b5babec3d8e4667a2cb9b5 is certainly good).  I'll bisect
> tomorrow if there are no ideas.

I bisected "invalid module format" woes to 9cb610d.

	-Mike