From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/6] xattr: use memdup_user()
Date: Wed, 08 Apr 2009 15:06:12 +0800 [thread overview]
Message-ID: <49DC4CE4.5080306@cn.fujitsu.com> (raw)
In-Reply-To: <49DC4CC0.9050805@cn.fujitsu.com>
Remove open-coded memdup_user()
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
fs/xattr.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index 197c4fc..d51b8f9 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -237,13 +237,9 @@ setxattr(struct dentry *d, const char __user *name, const void __user *value,
if (size) {
if (size > XATTR_SIZE_MAX)
return -E2BIG;
- kvalue = kmalloc(size, GFP_KERNEL);
- if (!kvalue)
- return -ENOMEM;
- if (copy_from_user(kvalue, value, size)) {
- kfree(kvalue);
- return -EFAULT;
- }
+ kvalue = memdup_user(value, size);
+ if (IS_ERR(kvalue))
+ return PTR_ERR(kvalue);
}
error = vfs_setxattr(d, kname, kvalue, size, flags);
--
1.5.4.rc3
next prev parent reply other threads:[~2009-04-08 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 7:05 [PATCH 0/6] fs: use memdup_user() Li Zefan
2009-04-08 7:06 ` Li Zefan [this message]
2009-04-08 7:06 ` [PATCH 2/6] btrfs: " Li Zefan
2009-04-08 7:07 ` [PATCH 3/6] sysfs: " Li Zefan
2009-04-08 7:08 ` [PATCH 4/6] xfs: " Li Zefan
2009-04-08 13:22 ` Christoph Hellwig
2009-04-08 17:31 ` Roland Dreier
2009-04-09 0:43 ` Li Zefan
2009-04-08 20:06 ` Felix Blyakher
2009-04-08 7:08 ` [PATCH 5/6] ncpfs: " Li Zefan
2009-04-08 7:09 ` [PATCH 6/6] ecryptfs: " Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DC4CE4.5080306@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox