Re: [tip:x86/apic] x86: make wakeup_secondary_cpu_via_init static

[Yinghai Lu <yinghai@kernel.org>]

Cyrill Gorcunov wrote:
> [Yinghai Lu - Wed, Apr 08, 2009 at 01:00:32PM +0000]
> | Commit-ID:  cdc1cb0d4445f39561a65204d26f89365f917550
> | Gitweb:     http://git.kernel.org/tip/cdc1cb0d4445f39561a65204d26f89365f917550
> | Author:     Yinghai Lu <yinghai@kernel.org>
> | AuthorDate: Fri, 3 Apr 2009 17:15:14 -0700
> | Committer:  Ingo Molnar <mingo@elte.hu>
> | CommitDate: Wed, 8 Apr 2009 14:50:28 +0200
> | 
> | x86: make wakeup_secondary_cpu_via_init static
> | 
> | Impact: cleanup
> | 
> | Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> | LKML-Reference: <49D6A692.6040400@kernel.org>
> | Signed-off-by: Ingo Molnar <mingo@elte.hu>
> | 
> | 
> | ---
> |  arch/x86/kernel/smpboot.c |    2 +-
> |  1 files changed, 1 insertions(+), 1 deletions(-)
> | 
> | diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> | index 58d24ef..bddf2cc 100644
> | --- a/arch/x86/kernel/smpboot.c
> | +++ b/arch/x86/kernel/smpboot.c
> | @@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
> |  	return (send_status | accept_status);
> |  }
> |  
> | -int __devinit
> | +static int __devinit
> |  wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
> |  {
> |  	unsigned long send_status, accept_status = 0;
> 
> Hi Yinghai,
> 
> just curious why it's not __cpuinit? Did I miss something?
> 

you could change that to __cpuinit.

also other three wakeup_seconary_cpu.

YH