From: Li Zefan <lizf@cn.fujitsu.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Christoph Hellwig <hch@infradead.org>,
felixb@sgi.com, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: use memdup_user()
Date: Thu, 09 Apr 2009 08:43:33 +0800 [thread overview]
Message-ID: <49DD44B5.9040702@cn.fujitsu.com> (raw)
In-Reply-To: <adabpr76oia.fsf@cisco.com>
Roland Dreier wrote:
> > wouldn't NULL be a better error return for this kind of interface,
> > matching kmalloc?
>
> I guess returning an error code from memdup_user() lets callers
> distinguish between ENOMEM and EFAULT. Not sure if that's important or
> not but there probably are at least some sites that care.
>
Right, and this API is simlilar to strndup_user().
next prev parent reply other threads:[~2009-04-09 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 7:05 [PATCH 0/6] fs: use memdup_user() Li Zefan
2009-04-08 7:06 ` [PATCH 1/6] xattr: " Li Zefan
2009-04-08 7:06 ` [PATCH 2/6] btrfs: " Li Zefan
2009-04-08 7:07 ` [PATCH 3/6] sysfs: " Li Zefan
2009-04-08 7:08 ` [PATCH 4/6] xfs: " Li Zefan
2009-04-08 13:22 ` Christoph Hellwig
2009-04-08 17:31 ` Roland Dreier
2009-04-09 0:43 ` Li Zefan [this message]
2009-04-08 20:06 ` Felix Blyakher
2009-04-08 7:08 ` [PATCH 5/6] ncpfs: " Li Zefan
2009-04-08 7:09 ` [PATCH 6/6] ecryptfs: " Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DD44B5.9040702@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=felixb@sgi.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox