Re: [PATCH] Additional keys for dell-wmi

Éric Piel
2009-04-09T08:23:29Z

Rafi Rubin schreef:
> Added key codes generated by screen rotation on the Latitude XT. 0xe046 is sent when changing to tablet mode, and 0xe047 when it returns to desktop mode.
>
> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
> ---
> drivers/platform/x86/dell-wmi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 2fab941..b76ef49 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -50,6 +50,8 @@ enum { KE_KEY, KE_SW, KE_END };
>
> static struct key_entry dell_wmi_keymap[] = {
> {KE_KEY, 0xe045, KEY_PROG1},
> + {KE_KEY, 0xe046, KEY_PROG2},
> + {KE_KEY, 0xe047, KEY_PROG3},
> {KE_END, 0}
Hello,
PROG2 and PROG3? That's so mundane! Fair enough, I've checked in
linux/input.h and couldn't find exactly fitting code keys
(SWITCHVIDEOMODE, VIDEO_NEXT, VIDEO_PREV are not exactly about
rotation). At least, it would be worth adding a comment after each line
about which key does what, so that it's not necessary to read the
changelog to know!

Eric