public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rafi Rubin <rafi@seas.upenn.edu>
To: "Éric Piel" <eric.piel@tremplin-utc.net>
Cc: Matthew Garrett <mjg@redhat.com>,
	mjg59@srcf.ucam.org, Len Brown <len.brown@intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Comments for additional keys for dell-wmi
Date: Thu, 09 Apr 2009 08:14:19 -0400	[thread overview]
Message-ID: <49DDE69B.6050504@seas.upenn.edu> (raw)
In-Reply-To: <49DDB053.4010809@tremplin-utc.net>

Commenting rotation events, in lieu of appropriate self commenting key names in input.h.

Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
---
 drivers/platform/x86/dell-wmi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index b76ef49..2d4f718 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -50,8 +50,8 @@ enum { KE_KEY, KE_SW, KE_END };

 static struct key_entry dell_wmi_keymap[] = {
        {KE_KEY, 0xe045, KEY_PROG1},
-       {KE_KEY, 0xe046, KEY_PROG2},
-       {KE_KEY, 0xe047, KEY_PROG3},
+       {KE_KEY, 0xe046, KEY_PROG2},     /* Going to tablet mode */
+       {KE_KEY, 0xe047, KEY_PROG3},     /* Coming from tablet mode */
        {KE_END, 0}
 };

-- 
1.6.2.1

`

  reply	other threads:[~2009-04-09 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 21:16 [PATCH] Additional keys for dell-wmi Rafi Rubin
2009-04-09  8:22 ` Éric Piel
2009-04-09 12:14   ` Rafi Rubin [this message]
2009-04-09 15:32 ` Matthew Garrett
2009-04-10 11:00   ` Éric Piel
2009-04-10 14:03     ` Rafi Rubin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DDE69B.6050504@seas.upenn.edu \
    --to=rafi@seas.upenn.edu \
    --cc=eric.piel@tremplin-utc.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox