From: "Éric Piel" <E.A.B.Piel@tudelft.nl>
To: Matthew Garrett <mjg@redhat.com>
Cc: Rafi Rubin <rafi@seas.upenn.edu>, Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Additional keys for dell-wmi
Date: Fri, 10 Apr 2009 13:00:59 +0200 [thread overview]
Message-ID: <49DF26EB.4040106@tudelft.nl> (raw)
In-Reply-To: <20090409153203.GB17194@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
Matthew Garrett schreef:
> On Wed, Apr 08, 2009 at 05:16:04PM -0400, Rafi Rubin wrote:
>
>> static struct key_entry dell_wmi_keymap[] = {
>> {KE_KEY, 0xe045, KEY_PROG1},
>> + {KE_KEY, 0xe046, KEY_PROG2},
>> + {KE_KEY, 0xe047, KEY_PROG3},
>
> Would this make more sense as a switch? That way userspace can know what
> state the screen is in.
>
Indeed, that seems more logical. And in addition, there is a switch
called SW_TABLET_MODE, which would fit perfectly.
I guess at initialisation you can consider it is in standard mode, and
actually sort out the real state on the first event received.
Eric
[-- Attachment #2: E_A_B_Piel.vcf --]
[-- Type: text/x-vcard, Size: 367 bytes --]
begin:vcard
fn;quoted-printable:=C3=89ric Piel
n;quoted-printable:Piel;=C3=89ric
org:Technical University of Delft;Software Engineering Research Group
adr:HB 08.080;;Mekelweg 4;Delft;;2628 CD;The Netherlands
email;internet:E.A.B.Piel@tudelft.nl
tel;work:+31 15 278 6338
tel;cell:+31 6 2437 9135
x-mozilla-html:FALSE
url:http://pieleric.free.fr
version:2.1
end:vcard
next prev parent reply other threads:[~2009-04-10 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 21:16 [PATCH] Additional keys for dell-wmi Rafi Rubin
2009-04-09 8:22 ` Éric Piel
2009-04-09 12:14 ` [PATCH] Comments for additional " Rafi Rubin
2009-04-09 15:32 ` [PATCH] Additional " Matthew Garrett
2009-04-10 11:00 ` Éric Piel [this message]
2009-04-10 14:03 ` Rafi Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DF26EB.4040106@tudelft.nl \
--to=e.a.b.piel@tudelft.nl \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox