Re: [PATCH] unbreak alpha percpu

Al Viro
2009-04-10T17:07:14Z

On Fri, Apr 10, 2009 at 05:50:30PM +0100, Al Viro wrote:
> On Fri, Apr 10, 2009 at 09:21:08AM -0700, Linus Torvalds wrote:
> >
> > Hmm. I certainly personally _much_ prefer this version.
> >
> > It looks like this actually simplifies things for S390 too (no more
> > simple_identifier_##var games), and generally just looks better. And
> > seeing that the S390 special case is no longer S390-specific is also a
> > good sign, imho.
>
> simple_identifier_##var has been debris from back when Ingo forced
> s390 to use asm-generic/percpu.h; if you look at it, you'll see that
> a) it hadn't worked (look at the argument list carefully) and
> b) get_cpu_var() has the working version anyway
>
> Less obvious part is that if it actually *would* work, we'd be screwed -
> unlike get_cpu_var() this sucker is called for things that are not
> simple variables; didn't happen for alpha, but did for s390.
>
> IOW, that's just an old piece of junk that got removed now.

Fsck... It breaks per_cpu_ptr() :-/ OK, back to square one, then...