From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] blktrace: fix output of BLK_TC_PC events
Date: Sat, 11 Apr 2009 16:15:53 +0800 [thread overview]
Message-ID: <49E051B9.8060805@cn.fujitsu.com> (raw)
In-Reply-To: <49D32387.9040106@cn.fujitsu.com>
Hi Ingo,
I would like to ask what's the status of these 2 patches.
Arnaldo acked on them.
Li Zefan wrote:
> BLK_TC_PC events should be treated differently with BLK_TC_FS events.
>
> Before this patch:
>
> # echo 1 > /sys/block/sda/sda1/trace/enable
> # echo pc > /sys/block/sda/sda1/trace/act_mask
> # echo blk > /debugfs/tracing/current_tracer
> # (generate some BLK_TC_PC events)
> # cat trace
> bash-2184 [000] 1774.275413: 8,7 I N [bash]
> bash-2184 [000] 1774.275435: 8,7 D N [bash]
> bash-2184 [000] 1774.275540: 8,7 I R [bash]
> bash-2184 [000] 1774.275547: 8,7 D R [bash]
> ksoftirqd/0-4 [000] 1774.275580: 8,7 C N 0 [0]
> bash-2184 [000] 1774.275648: 8,7 I R [bash]
> bash-2184 [000] 1774.275653: 8,7 D R [bash]
> ksoftirqd/0-4 [000] 1774.275682: 8,7 C N 0 [0]
> bash-2184 [000] 1774.275739: 8,7 I R [bash]
> bash-2184 [000] 1774.275744: 8,7 D R [bash]
> ksoftirqd/0-4 [000] 1774.275771: 8,7 C N 0 [0]
> bash-2184 [000] 1774.275804: 8,7 I R [bash]
> bash-2184 [000] 1774.275808: 8,7 D R [bash]
> ksoftirqd/0-4 [000] 1774.275836: 8,7 C N 0 [0]
>
> After this patch:
>
> # cat trace
> bash-2263 [000] 366.782149: 8,7 I N 0 (00 ..) [bash]
> bash-2263 [000] 366.782323: 8,7 D N 0 (00 ..) [bash]
> bash-2263 [000] 366.782557: 8,7 I R 8 (25 00 ..) [bash]
> bash-2263 [000] 366.782560: 8,7 D R 8 (25 00 ..) [bash]
> ksoftirqd/0-4 [000] 366.782582: 8,7 C N (25 00 ..) [0]
> bash-2263 [000] 366.782648: 8,7 I R 8 (5a 00 3f 00) [bash]
> bash-2263 [000] 366.782650: 8,7 D R 8 (5a 00 3f 00) [bash]
> ksoftirqd/0-4 [000] 366.782669: 8,7 C N (5a 00 3f 00) [0]
> bash-2263 [000] 366.782710: 8,7 I R 8 (5a 00 08 00) [bash]
> bash-2263 [000] 366.782713: 8,7 D R 8 (5a 00 08 00) [bash]
> ksoftirqd/0-4 [000] 366.782730: 8,7 C N (5a 00 08 00) [0]
> bash-2263 [000] 366.783375: 8,7 I R 36 (5a 00 08 00) [bash]
> bash-2263 [000] 366.783379: 8,7 D R 36 (5a 00 08 00) [bash]
> ksoftirqd/0-4 [000] 366.783404: 8,7 C N (5a 00 08 00) [0]
>
> This is what we do with PC events in user-space blktrace.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
next prev parent reply other threads:[~2009-04-11 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 8:18 [PATCH 1/2] blktrace: fix output of unknown events Li Zefan
2009-04-01 8:19 ` [PATCH 2/2] blktrace: fix output of BLK_TC_PC events Li Zefan
2009-04-01 11:00 ` Ingo Molnar
2009-04-01 12:52 ` Arnaldo Carvalho de Melo
2009-04-11 8:15 ` Li Zefan [this message]
2009-04-12 13:07 ` Ingo Molnar
2009-04-12 13:10 ` Jens Axboe
2009-04-12 13:37 ` Ingo Molnar
2009-04-13 0:43 ` Li Zefan
2009-04-13 0:40 ` Li Zefan
2009-04-13 22:22 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-01 12:46 ` [PATCH 1/2] blktrace: fix output of unknown events Arnaldo Carvalho de Melo
2009-04-13 22:22 ` [tip:tracing/core] " tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E051B9.8060805@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox