From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <srostedt@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: mark get_parent_ip() notrace
Date: Mon, 13 Apr 2009 14:17:07 +0800 [thread overview]
Message-ID: <49E2D8E3.4060708@cn.fujitsu.com> (raw)
In-Reply-To: <20090402122612.GB5965@nowhere>
Frederic Weisbecker wrote:
> On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
>> Impact: remove redundancy tracing log
>>
>> When tracer is "function" or "function_graph", too much
>> "get_parent_ip" are recorded in ring_buffer.
>
>
> Thanks, indeed this get_parent_ip was a bit harrassing
> in the traces, though I still don't understand why it is
> called so often.
>
> Anyway, tracing it seems to me not useful.
>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
>
>
Hi, Ingo,
Could you apply this fix?
get_parent_ip() is a helper function for ftace, and it is called
by preempt_disable() and preempt_enable(), so it is occurred very
often.
Lai.
next prev parent reply other threads:[~2009-04-13 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 6:18 [PATCH] tracing: mark get_parent_ip() notrace Lai Jiangshan
2009-04-02 12:26 ` Frederic Weisbecker
2009-04-13 6:17 ` Lai Jiangshan [this message]
2009-04-13 14:43 ` Steven Rostedt
2009-04-14 0:11 ` Ingo Molnar
2009-04-14 0:13 ` [tip:sched/urgent] tracing, sched: " tip-bot for Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E2D8E3.4060708@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox