From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] tracing/filters: allow on-the-fly filter switching
Date: Wed, 15 Apr 2009 09:12:58 +0800 [thread overview]
Message-ID: <49E5349A.9080402@cn.fujitsu.com> (raw)
In-Reply-To: <20090414205635.GA5968@nowhere>
> Ok, the whole design and concept looks nice.
>
> But you really need to think about a locking scheme to protect
> the filters from user files.
>
I noticed this and fixed it in that
"[PATCH 7/7] tracing/filters: make filter preds RCU safe"
I'll try to fix it on top of Tom's on-the-fly filter swithcing,
if Tom hasn't started to do this.
> Also, is filter_add_pred() supposed to be available for in-kernel
> uses by other tracers or something?
> If this is planned, the locking could be even deeper than my comments.
>
> Other than these comments:
>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
>
> Thanks!
next prev parent reply other threads:[~2009-04-15 1:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 8:17 [PATCH] tracing/filters: allow on-the-fly filter switching Tom Zanussi
2009-04-13 21:52 ` Ingo Molnar
2009-04-14 0:33 ` [tip:tracing/core] " tip-bot for Tom Zanussi
2009-04-14 20:56 ` [PATCH] " Frederic Weisbecker
2009-04-15 1:12 ` Li Zefan [this message]
2009-04-15 1:55 ` Frederic Weisbecker
2009-04-15 4:17 ` Tom Zanussi
2009-04-15 4:32 ` Tom Zanussi
2009-04-15 16:21 ` Frederic Weisbecker
2009-04-16 0:54 ` Li Zefan
2009-04-16 5:34 ` Tom Zanussi
2009-04-16 15:29 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E5349A.9080402@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox