* [PATCH] microblaze: iowrite upon timeout
@ 2009-04-16 20:49 Roel Kluin
2009-04-21 1:18 ` [microblaze-uclinux] " John Williams
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-04-16 20:49 UTC (permalink / raw)
To: monstr, microblaze-uclinux, lkml, Andrew Morton
retries reaches -1, so the iowrite occurrs upon timeout.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
index 62cc789..4b0f0fd 100644
--- a/arch/microblaze/kernel/early_printk.c
+++ b/arch/microblaze/kernel/early_printk.c
@@ -36,7 +36,7 @@ static void early_printk_putc(char c)
unsigned retries = 10000;
/* read status bit - 0x8 offset */
- while (retries-- && (in_be32(base_addr + 8) & (1 << 3)))
+ while (--retries && (in_be32(base_addr + 8) & (1 << 3)))
;
/* Only attempt the iowrite if we didn't timeout */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [microblaze-uclinux] [PATCH] microblaze: iowrite upon timeout
2009-04-16 20:49 [PATCH] microblaze: iowrite upon timeout Roel Kluin
@ 2009-04-21 1:18 ` John Williams
0 siblings, 0 replies; 2+ messages in thread
From: John Williams @ 2009-04-21 1:18 UTC (permalink / raw)
To: microblaze-uclinux; +Cc: monstr, lkml
On Fri, Apr 17, 2009 at 6:49 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> retries reaches -1, so the iowrite occurrs upon timeout.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: John Williams <john.williams@petalogix.com>
(also applied to PetaLogix SVN)
Thanks,
John
> ---
> diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
> index 62cc789..4b0f0fd 100644
> --- a/arch/microblaze/kernel/early_printk.c
> +++ b/arch/microblaze/kernel/early_printk.c
> @@ -36,7 +36,7 @@ static void early_printk_putc(char c)
>
> unsigned retries = 10000;
> /* read status bit - 0x8 offset */
> - while (retries-- && (in_be32(base_addr + 8) & (1 << 3)))
> + while (--retries && (in_be32(base_addr + 8) & (1 << 3)))
> ;
>
> /* Only attempt the iowrite if we didn't timeout */
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@itee.uq.edu.au
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>
>
--
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663 f: +61-7-30090663
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-21 1:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-16 20:49 [PATCH] microblaze: iowrite upon timeout Roel Kluin
2009-04-21 1:18 ` [microblaze-uclinux] " John Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).