From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Peter Oruba <peter.oruba@amd.com>,
amd64-microcode@amd64.org,
Andreas Herrmann <andreas.herrmann3@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: microcode driver newly spews warnings
Date: Thu, 16 Apr 2009 16:28:52 -0700 [thread overview]
Message-ID: <49E7BF34.6060002@zytor.com> (raw)
In-Reply-To: <49E7BD64.7060507@garzik.org>
Jeff Garzik wrote:
>> Jeff, did this do the trick for you?
>
> Yes -- but I worry about keeping sysfs files around too long?
>
> Jeff
OK, what isn't clear to me is what the proper return value is in this
case. In particular, how with the caller react to mc_sysdev_add()
returning a nonzero value, but still have the sysdev devices created and
retained?
What I would expect happen would be that sysdev_register_driver() would
return an error and we would unregister the notifier, which really isn't
the right thing -- if the intent is to keep the sysdev devices around
for a possible later update then we should presumably return zero there,
i.e. ignore the return value from microcode_init_cpu(); completely?
-hpa
next prev parent reply other threads:[~2009-04-16 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 18:23 microcode driver newly spews warnings Jeff Garzik
2009-04-13 18:25 ` Jeff Garzik
2009-04-13 18:27 ` Ingo Molnar
2009-04-15 14:10 ` Jeff Garzik
2009-04-15 14:51 ` Dmitry Adamushko
2009-04-16 23:07 ` Ingo Molnar
2009-04-16 23:21 ` Jeff Garzik
2009-04-16 23:28 ` H. Peter Anvin [this message]
2009-04-17 6:58 ` Dmitry Adamushko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E7BF34.6060002@zytor.com \
--to=hpa@zytor.com \
--cc=amd64-microcode@amd64.org \
--cc=andreas.herrmann3@amd.com \
--cc=dmitry.adamushko@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.oruba@amd.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox