Re: [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE

Jeremy Fitzhardinge
2009-04-17T06:59:15Z

Christoph Hellwig wrote:
> On Thu, Apr 16, 2009 at 11:35:38PM -0700, Jeremy Fitzhardinge wrote:
>
>> -DEFINE_TRACE(power_mark);
>> +DEFINE_TRACE(power_mark,
>> + TP_PROTO(struct power_trace *it, unsigned int type, unsigned int state),
>> + TP_ARGS(it, type, state));
>>
>
> Wrong indentation, the TP_ARGS should have the same level of indentation
> (one) as the TP_PROTO. Also true for all others.
>

It's just cut+replace+paste from the DECLARE_TRACE() definitions in
trace/power.h. The proper fix is to not duplicate all that stuff in the
first place, but I didn't want to introduce a gratuitous re-indent in
the process.

J