Re: [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE

Christoph Hellwig
2009-04-17T07:05:31Z

On Thu, Apr 16, 2009 at 11:58:56PM -0700, Jeremy Fitzhardinge wrote:
> Christoph Hellwig wrote:
>> On Thu, Apr 16, 2009 at 11:35:38PM -0700, Jeremy Fitzhardinge wrote:
>>
>>> -DEFINE_TRACE(power_mark);
>>> +DEFINE_TRACE(power_mark,
>>> + TP_PROTO(struct power_trace *it, unsigned int type, unsigned int state),
>>> + TP_ARGS(it, type, state));
>>>
>>
>> Wrong indentation, the TP_ARGS should have the same level of indentation
>> (one) as the TP_PROTO. Also true for all others.
>>
>
> It's just cut+replace+paste from the DECLARE_TRACE() definitions in
> trace/power.h. The proper fix is to not duplicate all that stuff in the
> first place, but I didn't want to introduce a gratuitous re-indent in
> the process.

When copying it to a new place I don't think that's a good enough
excuse.

Then again I'd really wish we could get Steve's recents bits merged for
various reasons. The whole DEFINE_TRACE thing only appeared in 2.6.30
and releasing that one kernel with the half-baked inferior version
sounds like a really bad idea.