From: Anthony Liguori <anthony@codemonkey.ws>
To: Huang Ying <ying.huang@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH -v2] Add MCE support to KVM
Date: Sat, 18 Apr 2009 10:54:38 -0500 [thread overview]
Message-ID: <49E9F7BE.4090904@codemonkey.ws> (raw)
In-Reply-To: <1239953345.6842.3.camel@yhuang-dev.sh.intel.com>
Huang Ying wrote:
> The related MSRs are emulated. MCE capability is exported via
> extension KVM_CAP_MCE and ioctl KVM_X86_GET_MCE_CAP_SUPPORTED. A new
> vcpu ioctl command KVM_X86_SETUP_MCE is used to setup MCE emulation
> such as the mcg_cap. MCE is injected via vcpu ioctl command
> KVM_X86_SET_MCE. Extended machine-check state (MCG_EXT_P) and CMCI are
> not simulated.
>
Maybe I'm missing something, but couldn't this be implemented entirely
within userspace? There's nothing VT/SVM specific about this. If the
issue is setting these MSRs from userspace via KVM_SET_MSRS isn't
enough, perhaps we should add userspace MSR handling.
Also, if you implement the MSR logic in userspace, it's pretty simple to
make it work in the non-TCG case which will be a requirement for
upstream merging.
Regards,
Anthony LIguori
next prev parent reply other threads:[~2009-04-18 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 7:29 [PATCH -v2] Add MCE support to KVM Huang Ying
2009-04-18 15:54 ` Anthony Liguori [this message]
2009-04-19 8:39 ` Avi Kivity
2009-04-21 16:06 ` Anthony Liguori
2009-04-21 16:19 ` Avi Kivity
2009-04-21 16:12 ` Anthony Liguori
2009-04-21 16:21 ` Avi Kivity
2009-04-21 19:55 ` Anthony Liguori
2009-04-21 20:00 ` Avi Kivity
2009-04-21 20:08 ` Anthony Liguori
2009-04-21 20:45 ` Avi Kivity
2009-04-21 21:16 ` Anthony Liguori
2009-04-22 5:57 ` Avi Kivity
2009-04-22 13:32 ` Anthony Liguori
2009-04-22 13:58 ` Avi Kivity
2009-04-22 2:32 ` Huang Ying
2009-04-20 1:19 ` Huang Ying
2009-04-20 3:57 ` Kyle Moffett
2009-04-20 5:04 ` Huang Ying
2009-04-20 5:30 ` Andi Kleen
2009-04-22 2:42 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E9F7BE.4090904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox