From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757506AbZDRVKk (ORCPT ); Sat, 18 Apr 2009 17:10:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755092AbZDRVKG (ORCPT ); Sat, 18 Apr 2009 17:10:06 -0400 Received: from hera.kernel.org ([140.211.167.34]:60837 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbZDRVKE (ORCPT ); Sat, 18 Apr 2009 17:10:04 -0400 Message-ID: <49EA4189.9040204@kernel.org> Date: Sat, 18 Apr 2009 14:09:29 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, gorcunov@openvz.org, tglx@linutronix.de, gorcunov@gmail.com, mingo@elte.hu CC: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section References: <20090418194528.GD25510@lenovo> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tip-bot for Cyrill Gorcunov wrote: > Commit-ID: 1f51f72326c4d16f402bdfed99c8dae20eb67863 > Gitweb: http://git.kernel.org/tip/1f51f72326c4d16f402bdfed99c8dae20eb67863 > Author: Cyrill Gorcunov > AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400 > Committer: Ingo Molnar > CommitDate: Sat, 18 Apr 2009 22:58:58 +0200 > > x86: smpboot - wakeup_secondary should be done via __cpuinit section > > A caller (do_boot_cpu) already has __cpuinit attribute. > > Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't > lead to panic at moment. > > [ Impact: cleanup ] > > Signed-off-by: Cyrill Gorcunov > LKML-Reference: <20090418194528.GD25510@lenovo> > Signed-off-by: Ingo Molnar > > > --- > arch/x86/kernel/smpboot.c | 4 ++-- there are other two in numaq and es7000. can you fix them too? YH