* [PATCH -tip] x86: smpboot - wakeup_secondary should be done via __cpuinit section
@ 2009-04-18 19:45 Cyrill Gorcunov
2009-04-18 21:02 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-19 8:25 ` tip-bot for Cyrill Gorcunov
0 siblings, 2 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2009-04-18 19:45 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner
A caller (do_boot_cpu) already has __cpuinit attribute.
Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
lead to panic at moment.
[ Impact: cleanup ]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
arch/x86/kernel/smpboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.git/arch/x86/kernel/smpboot.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/smpboot.c
+++ linux-2.6.git/arch/x86/kernel/smpboot.c
@@ -504,7 +504,7 @@ void __inquire_remote_apic(int apicid)
* INIT, INIT, STARTUP sequence will reset the chip hard for us, and this
* won't ... remember to clear down the APIC, etc later.
*/
-int __devinit
+int __cpuinit
wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
@@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical
return (send_status | accept_status);
}
-static int __devinit
+static int __cpuinit
wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
^ permalink raw reply [flat|nested] 5+ messages in thread* [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section
2009-04-18 19:45 [PATCH -tip] x86: smpboot - wakeup_secondary should be done via __cpuinit section Cyrill Gorcunov
@ 2009-04-18 21:02 ` tip-bot for Cyrill Gorcunov
2009-04-18 21:09 ` Yinghai Lu
2009-04-19 8:25 ` tip-bot for Cyrill Gorcunov
1 sibling, 1 reply; 5+ messages in thread
From: tip-bot for Cyrill Gorcunov @ 2009-04-18 21:02 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, gorcunov, tglx, gorcunov, mingo
Commit-ID: 1f51f72326c4d16f402bdfed99c8dae20eb67863
Gitweb: http://git.kernel.org/tip/1f51f72326c4d16f402bdfed99c8dae20eb67863
Author: Cyrill Gorcunov <gorcunov@gmail.com>
AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 18 Apr 2009 22:58:58 +0200
x86: smpboot - wakeup_secondary should be done via __cpuinit section
A caller (do_boot_cpu) already has __cpuinit attribute.
Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
lead to panic at moment.
[ Impact: cleanup ]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
LKML-Reference: <20090418194528.GD25510@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/smpboot.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index bf8ad63..d2e8de9 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -504,7 +504,7 @@ void __inquire_remote_apic(int apicid)
* INIT, INIT, STARTUP sequence will reset the chip hard for us, and this
* won't ... remember to clear down the APIC, etc later.
*/
-int __devinit
+int __cpuinit
wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
@@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
return (send_status | accept_status);
}
-static int __devinit
+static int __cpuinit
wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section
2009-04-18 21:02 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
@ 2009-04-18 21:09 ` Yinghai Lu
2009-04-18 21:18 ` Cyrill Gorcunov
0 siblings, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2009-04-18 21:09 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, gorcunov, tglx, gorcunov, mingo
Cc: linux-tip-commits
tip-bot for Cyrill Gorcunov wrote:
> Commit-ID: 1f51f72326c4d16f402bdfed99c8dae20eb67863
> Gitweb: http://git.kernel.org/tip/1f51f72326c4d16f402bdfed99c8dae20eb67863
> Author: Cyrill Gorcunov <gorcunov@gmail.com>
> AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sat, 18 Apr 2009 22:58:58 +0200
>
> x86: smpboot - wakeup_secondary should be done via __cpuinit section
>
> A caller (do_boot_cpu) already has __cpuinit attribute.
>
> Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
> lead to panic at moment.
>
> [ Impact: cleanup ]
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> LKML-Reference: <20090418194528.GD25510@lenovo>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
>
> ---
> arch/x86/kernel/smpboot.c | 4 ++--
there are other two in numaq and es7000.
can you fix them too?
YH
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section
2009-04-18 21:09 ` Yinghai Lu
@ 2009-04-18 21:18 ` Cyrill Gorcunov
0 siblings, 0 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2009-04-18 21:18 UTC (permalink / raw)
To: Yinghai Lu; +Cc: mingo, hpa, linux-kernel, tglx, mingo, linux-tip-commits
On 4/19/09, Yinghai Lu <yinghai@kernel.org> wrote:
> tip-bot for Cyrill Gorcunov wrote:
>> Commit-ID: 1f51f72326c4d16f402bdfed99c8dae20eb67863
>> Gitweb:
>> http://git.kernel.org/tip/1f51f72326c4d16f402bdfed99c8dae20eb67863
>> Author: Cyrill Gorcunov <gorcunov@gmail.com>
>> AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
>> Committer: Ingo Molnar <mingo@elte.hu>
>> CommitDate: Sat, 18 Apr 2009 22:58:58 +0200
>>
>> x86: smpboot - wakeup_secondary should be done via __cpuinit section
>>
>> A caller (do_boot_cpu) already has __cpuinit attribute.
>>
>> Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
>> lead to panic at moment.
>>
>> [ Impact: cleanup ]
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>> LKML-Reference: <20090418194528.GD25510@lenovo>
>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>>
>>
>> ---
>> arch/x86/kernel/smpboot.c | 4 ++--
>
> there are other two in numaq and es7000.
>
> can you fix them too?
>
> YH
>
>
Will do tomorrow morning
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section
2009-04-18 19:45 [PATCH -tip] x86: smpboot - wakeup_secondary should be done via __cpuinit section Cyrill Gorcunov
2009-04-18 21:02 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
@ 2009-04-19 8:25 ` tip-bot for Cyrill Gorcunov
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Cyrill Gorcunov @ 2009-04-19 8:25 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, gorcunov, tglx, gorcunov, mingo
Commit-ID: cece3155d869a50ba534ed161b5a05e8a29dcad0
Gitweb: http://git.kernel.org/tip/cece3155d869a50ba534ed161b5a05e8a29dcad0
Author: Cyrill Gorcunov <gorcunov@gmail.com>
AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 19 Apr 2009 10:22:14 +0200
x86: smpboot - wakeup_secondary should be done via __cpuinit section
A caller (do_boot_cpu) already has __cpuinit attribute.
Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't
lead to panic at moment.
[ Impact: cleanup ]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
LKML-Reference: <20090418194528.GD25510@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/smpboot.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index bf8ad63..d2e8de9 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -504,7 +504,7 @@ void __inquire_remote_apic(int apicid)
* INIT, INIT, STARTUP sequence will reset the chip hard for us, and this
* won't ... remember to clear down the APIC, etc later.
*/
-int __devinit
+int __cpuinit
wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
@@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip)
return (send_status | accept_status);
}
-static int __devinit
+static int __cpuinit
wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
{
unsigned long send_status, accept_status = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-19 8:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-18 19:45 [PATCH -tip] x86: smpboot - wakeup_secondary should be done via __cpuinit section Cyrill Gorcunov
2009-04-18 21:02 ` [tip:x86/apic] " tip-bot for Cyrill Gorcunov
2009-04-18 21:09 ` Yinghai Lu
2009-04-18 21:18 ` Cyrill Gorcunov
2009-04-19 8:25 ` tip-bot for Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox