From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2 v3] tracing/events: provide string with undefined size support
Date: Sun, 19 Apr 2009 14:15:36 +0800 [thread overview]
Message-ID: <49EAC188.1040409@cn.fujitsu.com> (raw)
In-Reply-To: <1240117295-6873-2-git-send-email-fweisbec@gmail.com>
> @@ -417,18 +495,22 @@ static struct ftrace_event_call event_##call; \
> \
> static void ftrace_raw_event_##call(proto) \
> { \
> + struct ftrace_str_offsets_##call __maybe_unused __str_offsets; \
> struct ftrace_event_call *call = &event_##call; \
> struct ring_buffer_event *event; \
> struct ftrace_raw_##call *entry; \
> unsigned long irq_flags; \
> + int __str_size = 0; \
> int pc; \
> \
> local_save_flags(irq_flags); \
> pc = preempt_count(); \
> \
> + tstruct; \
> + \
> event = trace_current_buffer_lock_reserve(event_##call.id, \
> - sizeof(struct ftrace_raw_##call), \
> - irq_flags, pc); \
> + sizeof(struct ftrace_raw_##call) + __str_size,\
sizeof(*entry) will make it much shorter. ;)
> + irq_flags, pc); \
> if (!event) \
> return; \
> entry = ring_buffer_event_data(event); \
next prev parent reply other threads:[~2009-04-19 6:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 5:01 [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Frederic Weisbecker
2009-04-19 5:01 ` [PATCH 1/2 v3] tracing/events: provide string with undefined size support Frederic Weisbecker
2009-04-19 6:15 ` Li Zefan [this message]
2009-04-19 12:35 ` Frederic Weisbecker
2009-04-21 18:16 ` Frederic Weisbecker
2009-04-21 18:33 ` Steven Rostedt
2009-04-21 21:58 ` Steven Rostedt
2009-04-21 22:00 ` Steven Rostedt
2009-04-21 22:12 ` Frederic Weisbecker
2009-04-21 22:21 ` Steven Rostedt
2009-04-21 23:32 ` [PATCH][GIT-PULL] tracing/events: protect __get_str() Frederic Weisbecker
2009-04-22 10:25 ` Ingo Molnar
2009-04-22 10:41 ` [PATCH 1/2 v3] tracing/events: provide string with undefined size support Ingo Molnar
2009-04-19 5:01 ` [PATCH 2/2 v3] tracing/lock: provide lock_acquired event support for dynamic size string Frederic Weisbecker
2009-04-21 21:59 ` Steven Rostedt
2009-04-19 6:14 ` [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Li Zefan
2009-04-19 12:34 ` Frederic Weisbecker
2009-04-19 13:49 ` [PATCH] tracing/core: Add current context on tracing recursion warning Frederic Weisbecker
2009-04-19 14:01 ` Ingo Molnar
2009-04-19 14:22 ` Frederic Weisbecker
2009-04-19 18:45 ` Ingo Molnar
2009-04-19 18:48 ` Frédéric Weisbecker
2009-04-19 18:47 ` Ingo Molnar
2009-04-19 17:28 ` Frederic Weisbecker
2009-04-20 0:37 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EAC188.1040409@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox