From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755092AbZDTLMl (ORCPT ); Mon, 20 Apr 2009 07:12:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753750AbZDTLMa (ORCPT ); Mon, 20 Apr 2009 07:12:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60109 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbZDTLM3 (ORCPT ); Mon, 20 Apr 2009 07:12:29 -0400 Message-ID: <49EC584B.3060809@redhat.com> Date: Mon, 20 Apr 2009 14:11:07 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Alan Cox CC: Izik Eidus , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, aarcange@redhat.com, chrisw@redhat.com, mtosatti@redhat.com, hugh@veritas.com Subject: Re: [PATCH 5/5] add ksm kernel shared memory driver. References: <1240191366-10029-1-git-send-email-ieidus@redhat.com> <1240191366-10029-2-git-send-email-ieidus@redhat.com> <1240191366-10029-3-git-send-email-ieidus@redhat.com> <1240191366-10029-4-git-send-email-ieidus@redhat.com> <1240191366-10029-5-git-send-email-ieidus@redhat.com> <1240191366-10029-6-git-send-email-ieidus@redhat.com> <20090420110223.76ba4593@lxorguk.ukuu.org.uk> In-Reply-To: <20090420110223.76ba4593@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: > The minor number you are using already belongs to another project. > > 10,234 is free but it would be good to know what device naming is > proposed. I imagine other folks would like to know why you aren't using > sysfs or similar or extending /dev/kvm ? > ksm was deliberately made independent of kvm. While there may or may not be uses of ksm without kvm (you could run ordinary qemu, but no one would do this in a production deployment), keeping them separate helps avoid unnecessary interdependencies. For example all tlb flushes are mediated through mmu notifiers instead of ksm hooking directly into kvm. -- error compiling committee.c: too many arguments to function