From: "H. Peter Anvin" <h.peter.anvin@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Brian Maly <bmaly@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dannf@hp.com" <dannf@hp.com>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH] rtc: add x86 support for rtc-efi
Date: Mon, 20 Apr 2009 11:21:37 -0700 [thread overview]
Message-ID: <49ECBD31.9010607@intel.com> (raw)
In-Reply-To: <20090420172045.GA17887@elte.hu>
Ingo Molnar wrote:
> * Brian Maly <bmaly@redhat.com> wrote:
>
>>> Hm, it would be nice to first unify the relevant bits of
>>> arch/x86/kernel/time_{32|64}.c into arch/x86/kernel/time.c, and
>>> then we can apply such patches without duplicative effects.
>> Ingo,
>>
>> Are you OK with consolidating this into arch/x86/kernel/rtc.c as
>> Huang Ying had suggested? This seems like the most logical place
>> for the rtc-efi init to happen, but your suggestion to consolidate
>> this into arch/x86/kernel.time.c may have advantages that I am not
>> aware of. Anyway, I would appreciate any insight/opinions on this
>> if you have any. Thanks.
>
> Yes, that indeed sounds like an even better place for it.
>
Furthermore, the EFI RTC code probably should be in its own file.
In fact, arch/x86/kernel really could use more subdirectories; at least
the EFI and UV-specific code should be be moved out.
-hpa
next prev parent reply other threads:[~2009-04-20 18:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 17:49 [PATCH] rtc: add x86 support for rtc-efi Brian Maly
2009-04-06 19:31 ` dann frazier
2009-04-06 22:26 ` H. Peter Anvin
2009-04-06 22:55 ` Brian Maly
2009-04-08 16:23 ` dann frazier
2009-04-09 23:18 ` Andrew Morton
2009-04-10 13:51 ` Ingo Molnar
2009-04-20 17:15 ` Brian Maly
2009-04-20 17:20 ` Ingo Molnar
2009-04-20 18:21 ` H. Peter Anvin [this message]
2009-05-19 20:10 ` Brian Maly
2009-05-25 5:49 ` Huang Ying
2009-05-25 16:28 ` H. Peter Anvin
2009-05-27 23:21 ` Ingo Molnar
2009-04-10 1:08 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ECBD31.9010607@intel.com \
--to=h.peter.anvin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bmaly@redhat.com \
--cc=dannf@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).