From: Clemens Ladisch <clemens@ladisch.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] go7007: Convert to the new i2c device binding model
Date: Tue, 21 Apr 2009 09:39:11 +0200 [thread overview]
Message-ID: <49ED781F.2000802@ladisch.de> (raw)
In-Reply-To: <20090420194237.52630423@hyperion.delvare>
Jean Delvare wrote:
> I am puzzled by the s2250 I2C address, 0x86 really doesn't fit in
> 7 bits, there must be something wrong.
> - .addr = 0x34,
> + .addr = 0x86, /* ?? */
> -#define S2250_VIDDEC 0x86
Many I2C controllers use an 8-bit address register, with the lowest bit
being the read/write bit (because this is the order in which the bits
are transmitted over the bus). So it looks as if the actual address
_is_ 0x34; the S2250_VIDDEC symbol is probably a relict of the old
driver that programmed the I2C controller directly.
Best regards,
Clemens
next prev parent reply other threads:[~2009-04-21 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 17:42 [PATCH] go7007: Convert to the new i2c device binding model Jean Delvare
2009-04-21 7:39 ` Clemens Ladisch [this message]
2009-04-21 13:33 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ED781F.2000802@ladisch.de \
--to=clemens@ladisch.de \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).