From: Mario Limonciello <mario_limonciello@dell.com>
To: mjg59@srcf.ucam.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] Don't load Dell-WMI on non WMI systems
Date: Tue, 21 Apr 2009 13:01:55 -0500 [thread overview]
Message-ID: <49EE0A13.50403@dell.com> (raw)
In-Reply-To: <49ECBAE2.2080308@dell.com>
[-- Attachment #1.1: Type: text/plain, Size: 282 bytes --]
Hi:
I've noticed that the dell-wmi module will load on systems even if WMI
isn't supported. As this is dependent upon BIOS version, dell-wmi
should return -ENODEV in these situations.
Regards
--
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: dell-wmi-dont-load-on-non-wmi-system.patch --]
[-- Type: text/x-patch; name="dell-wmi-dont-load-on-non-wmi-system.patch", Size: 393 bytes --]
--- a/drivers/platform/x86/dell-wmi.c~ 2009-04-21 12:41:50.000000000 -0500
+++ b/drivers/platform/x86/dell-wmi.c 2009-04-21 12:30:35.000000000 -0500
@@ -255,8 +255,10 @@
return err;
}
- } else
- printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n");
+ } else {
+ printk(KERN_ERR "dell-wmi: No known WMI GUID found\n");
+ return -ENODEV;
+ }
return 0;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2009-04-21 18:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 18:11 Add support for Eject hotkey in dell-wmi Mario Limonciello
2009-04-20 18:23 ` Matthew Garrett
2009-04-20 18:25 ` Mario Limonciello
2009-04-20 18:28 ` Matthew Garrett
2009-04-20 18:45 ` Mario Limonciello
[not found] ` <49ECC279.2080607@dell.com>
2009-04-20 18:48 ` Matthew Garrett
2009-04-20 18:50 ` Mario Limonciello
2009-04-21 18:00 ` [PATCH 1/3] Add support for more dell-wmi hotkeys Mario Limonciello
2009-04-21 18:31 ` Matthew Garrett
2009-04-21 19:06 ` Mario Limonciello
2009-04-21 19:12 ` Matthew Garrett
2009-04-21 19:16 ` Mario Limonciello
2009-04-21 19:18 ` Matthew Garrett
2009-04-21 19:22 ` Mario Limonciello
2009-04-29 16:57 ` Matthew Garrett
2009-04-29 18:16 ` Mario Limonciello
2009-04-29 18:31 ` Matthew Garrett
2009-04-29 19:23 ` Valdis.Kletnieks
2009-04-29 20:30 ` Matthew Garrett
2009-04-29 21:24 ` Mario Limonciello
2009-04-29 21:29 ` Matthew Garrett
2009-04-29 22:31 ` Mario Limonciello
2009-04-29 17:15 ` Matthew Garrett
2009-04-29 18:20 ` Mario Limonciello
2009-04-29 18:29 ` Matthew Garrett
2009-05-04 16:38 ` Mario Limonciello
2009-05-10 2:23 ` Matthew Garrett
2009-05-13 17:50 ` Mario Limonciello
2009-04-21 18:01 ` Mario Limonciello [this message]
2009-04-21 18:03 ` [PATCH 3/3] Mark OSD type scancodes Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EE0A13.50403@dell.com \
--to=mario_limonciello@dell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).