Re: April 22 Next : net/rfkill randconfig failure

Ken Lewis
2009-04-23T10:33:30Z

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

2009/4/23 Alexander Beregalov <a.beregalov@gmail.com>:
> 2009/4/22 Sachin Sant <sachinp@in.ibm.com>:
>> Today's next tree build (x86 randconfig) failed with
>>
>> net/rfkill/rfkill.c: In function 'update_rfkill_state':
>> net/rfkill/rfkill.c:99: error: implicit declaration of function
>> 'rfkill_led_trigger'
>> make[2]: *** [net/rfkill/rfkill.o] Error 1
>>
>> .config attached
>>
>
> Add CCs

I'm getting the same issue, but my .config does not include
CONFIG_RFKILL_LEDS. I use the attached patch to ensure the functions
were defined. Apols for the formatting: first patch atttempt.

Take care.
Ken.

[-- Attachment #2: next-20090423-rfkill-diff.txt --]
[-- Type: text/plain, Size: 532 bytes --]

diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
index 53430a7..fcdd5e0 100644
--- a/net/rfkill/rfkill.c
+++ b/net/rfkill/rfkill.c
@@ -75,6 +75,12 @@ static void rfkill_led_trigger_activate(struct led_classdev *led)

rfkill_led_trigger(rfkill, rfkill->state);
}
+#else
+static void rfkill_led_trigger(struct rfkill *rfkill,
+ enum rfkill_state state)
+{ }
+static void rfkill_led_trigger_activate(struct led_classdev *led)
+{ }
#endif /* CONFIG_RFKILL_LEDS */

static void rfkill_uevent(struct rfkill *rfkill)