* [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()
@ 2009-04-22 19:06 Coly Li
2009-04-22 20:33 ` David Daney
0 siblings, 1 reply; 4+ messages in thread
From: Coly Li @ 2009-04-22 19:06 UTC (permalink / raw)
To: LKML; +Cc: David Daney, Ingo Molnar
This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
clocksource *cs', which fixes compile warning for incompatible parameter type.
Signed-off-by: Coly Li <coly.li@suse.de>
Cc: David Daney <ddaney@caviumnetworks.com>
Cc: Ingo Molnar <mingo@elte.hu>
---
arch/mips/cavium-octeon/csrc-octeon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/cavium-octeon/csrc-octeon.c
b/arch/mips/cavium-octeon/csrc-octeon.c
index 70fd92c..96110f2 100644
--- a/arch/mips/cavium-octeon/csrc-octeon.c
+++ b/arch/mips/cavium-octeon/csrc-octeon.c
@@ -38,7 +38,7 @@ void octeon_init_cvmcount(void)
local_irq_restore(flags);
}
-static cycle_t octeon_cvmcount_read(void)
+static cycle_t octeon_cvmcount_read(struct clocksource *cs)
{
return read_c0_cvmcount();
}
--
Coly Li
SuSE Labs
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()
2009-04-22 19:06 [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read() Coly Li
@ 2009-04-22 20:33 ` David Daney
2009-05-05 16:13 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: David Daney @ 2009-04-22 20:33 UTC (permalink / raw)
To: coly.li; +Cc: LKML, Ingo Molnar
Coly Li wrote:
> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
>
> Signed-off-by: Coly Li <coly.li@suse.de>
> Cc: David Daney <ddaney@caviumnetworks.com>
> Cc: Ingo Molnar <mingo@elte.hu>
It looks good to me:
Reviewed-by: David Daney <ddaney@caviumnetworks.com>
> ---
> arch/mips/cavium-octeon/csrc-octeon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/csrc-octeon.c
> b/arch/mips/cavium-octeon/csrc-octeon.c
> index 70fd92c..96110f2 100644
> --- a/arch/mips/cavium-octeon/csrc-octeon.c
> +++ b/arch/mips/cavium-octeon/csrc-octeon.c
> @@ -38,7 +38,7 @@ void octeon_init_cvmcount(void)
> local_irq_restore(flags);
> }
>
> -static cycle_t octeon_cvmcount_read(void)
> +static cycle_t octeon_cvmcount_read(struct clocksource *cs)
> {
> return read_c0_cvmcount();
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()
2009-04-22 20:33 ` David Daney
@ 2009-05-05 16:13 ` Ralf Baechle
2009-05-05 17:21 ` Coly Li
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2009-05-05 16:13 UTC (permalink / raw)
To: David Daney; +Cc: coly.li, LKML, Ingo Molnar
On Wed, Apr 22, 2009 at 01:33:56PM -0700, David Daney wrote:
> Coly Li wrote:
>> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
>> clocksource *cs', which fixes compile warning for incompatible parameter type.
>>
>> Signed-off-by: Coly Li <coly.li@suse.de>
>> Cc: David Daney <ddaney@caviumnetworks.com>
>> Cc: Ingo Molnar <mingo@elte.hu>
>
> It looks good to me:
>
> Reviewed-by: David Daney <ddaney@caviumnetworks.com>
Applied, thanks.
Coly, if you modify MIPS code, please cc the linux-mips mailing list and
myself or generally consult the MAINTAINERS file for who to cc on patches.
Thanks!
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()
2009-05-05 16:13 ` Ralf Baechle
@ 2009-05-05 17:21 ` Coly Li
0 siblings, 0 replies; 4+ messages in thread
From: Coly Li @ 2009-05-05 17:21 UTC (permalink / raw)
To: Ralf Baechle; +Cc: David Daney, LKML, Ingo Molnar
Ralf Baechle Wrote:
> On Wed, Apr 22, 2009 at 01:33:56PM -0700, David Daney wrote:
>
>> Coly Li wrote:
>>> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
>>> clocksource *cs', which fixes compile warning for incompatible parameter type.
>>>
>>> Signed-off-by: Coly Li <coly.li@suse.de>
>>> Cc: David Daney <ddaney@caviumnetworks.com>
>>> Cc: Ingo Molnar <mingo@elte.hu>
>> It looks good to me:
>>
>> Reviewed-by: David Daney <ddaney@caviumnetworks.com>
>
> Applied, thanks.
>
> Coly, if you modify MIPS code, please cc the linux-mips mailing list and
> myself or generally consult the MAINTAINERS file for who to cc on patches.
>
Ralf, I keep you advice in mind. Thanks.
--
Coly Li
SuSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-05 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-22 19:06 [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read() Coly Li
2009-04-22 20:33 ` David Daney
2009-05-05 16:13 ` Ralf Baechle
2009-05-05 17:21 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox