public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jack Steiner <steiner@sgi.com>
Subject: [PATCH] x86: check boundry in setup_node_bootmem()
Date: Wed, 22 Apr 2009 14:19:27 -0700	[thread overview]
Message-ID: <49EF89DF.9090404@kernel.org> (raw)


|commit dc098551918093901d8ac8936e9d1a1b891b56ed
|Author: Jack Steiner <steiner@sgi.com>
|Date:   Fri Apr 17 09:22:42 2009 -0500
|
|    x86/uv: fix init of memory-less nodes
|    
|    Add support for nodes that have cpus but no memory.
|    The current code was failing to add these nodes
|    to the nodes_present_map.
|    
|    v2: Fixes case caught by David Rientjes - missed support
|        for the x2apic SRAT table.
|    
|    [ Impact: fix potential boot crash on memory-less UV nodes. ]

cause one two sockets system that node1 doesn't have ram install crash.

becuase that patch make node_possible include cpu nodes do not have memory.

so try to check bounday in setup_node_bootmem

[Impact: fix boot panic caused by node_possible_node change]

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c
index d73aaa8..b311a1e 100644
--- a/arch/x86/mm/numa_64.c
+++ b/arch/x86/mm/numa_64.c
@@ -188,6 +188,9 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
 	const int pgdat_size = roundup(sizeof(pg_data_t), PAGE_SIZE);
 	int nid;
 
+	if (!end)
+		return;
+
 	start = roundup(start, ZONE_ALIGN);
 
 	printk(KERN_INFO "Bootmem setup node %d %016lx-%016lx\n", nodeid,

             reply	other threads:[~2009-04-22 21:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 21:19 Yinghai Lu [this message]
2009-04-23  8:00 ` [tip:x86/urgent] x86: check boundary in setup_node_bootmem() tip-bot for Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EF89DF.9090404@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox