From: Coly Li <coly.li@suse.de>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Chris Zankel <chris@zankel.net>
Subject: Re: [PATCH 7/7] xtensa: add parameter to ccount_read()
Date: Thu, 23 Apr 2009 12:36:16 +0800 [thread overview]
Message-ID: <49EFF040.1010205@suse.de> (raw)
In-Reply-To: <20090422220719.GA3602@cmpxchg.org>
Johannes Weiner Wrote:
> On Thu, Apr 23, 2009 at 03:12:22AM +0800, Coly Li wrote:
>> This patch modifies parameter of au1x_counter1_read() from 'void' to 'struct
>> clocksource *cs', which fixes compile warning for incompatible parameter type.
>
> Changelog should be adjusted to say 'ccount_read()' here ;)
>
Obviously this is a copy+past mistake. I modified the email title, but missed
the changelog :(
>> Signed-off-by: Coly Li <coly.li@suse.de>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Ingo Molnar <mingo@elte.hu>
>> ---
>> arch/xtensa/kernel/time.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/xtensa/kernel/time.c b/arch/xtensa/kernel/time.c
>> index 8848120..9638641 100644
>> --- a/arch/xtensa/kernel/time.c
>> +++ b/arch/xtensa/kernel/time.c
>> @@ -30,7 +30,7 @@ unsigned long ccount_per_jiffy; /* per 1/HZ */
>> unsigned long nsec_per_ccount; /* nsec per ccount increment */
>> #endif
>>
>> -static cycle_t ccount_read(void)
>> +static cycle_t ccount_read(struct clocksource *cs)
>> {
>> return (cycle_t)get_ccount();
>> }
>
> Thanks. Copied Chris as well.
Need I resend another patch which fixes the changelog ?
Thanks.
--
Coly Li
SuSE Labs
prev parent reply other threads:[~2009-04-23 4:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 19:12 [PATCH 7/7] xtensa: add parameter to ccount_read() Coly Li
2009-04-22 22:07 ` Johannes Weiner
2009-04-23 4:36 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EFF040.1010205@suse.de \
--to=coly.li@suse.de \
--cc=chris@zankel.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox