From: Arjan van de Ven <arjan@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org
Subject: Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build
Date: Thu, 23 Apr 2009 08:07:51 -0700 [thread overview]
Message-ID: <49F08447.9040003@linux.intel.com> (raw)
In-Reply-To: <20090423151024.GO13896@one.firstfloor.org>
Andi Kleen wrote:
> On Thu, Apr 23, 2009 at 04:38:59PM +0200, Johannes Weiner wrote:
>>> +void warn_slowpath_null(const char *file, int line)
>>> +{
>>> + warn_slowpath_fmt(file, line, (const char *) { 0 });
>>> +}
>>> +EXPORT_SYMBOL(warn_slowpath_null);
>> I would WTF here without knowing the warning. Can you add a comment?
>>
>> Otherwise, Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> Ok version with comment.
Makes sense if we plan to keep gcc 3.2 supported; if we plan to drop it then we shouldn't bother.
Anyway
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
next prev parent reply other threads:[~2009-04-23 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 22:11 [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build Andi Kleen
2009-04-23 11:58 ` Jesper Nilsson
2009-04-23 12:18 ` Andi Kleen
2009-04-23 12:02 ` Johannes Weiner
2009-04-23 12:23 ` Andi Kleen
2009-04-23 14:38 ` Johannes Weiner
2009-04-23 15:10 ` Andi Kleen
2009-04-23 15:07 ` Arjan van de Ven [this message]
2009-04-23 15:23 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F08447.9040003@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@osdl.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox